Skip to content

Fix Android Build for AWS#15696

Closed
ahmedyarub wants to merge 6 commits intomicrosoft:masterfrom
ahmedyarub:fix_aws_android
Closed

Fix Android Build for AWS#15696
ahmedyarub wants to merge 6 commits intomicrosoft:masterfrom
ahmedyarub:fix_aws_android

Conversation

@ahmedyarub
Copy link
Contributor

Describe the pull request
Adds toolchain chaining to external builds

  • What does your PR fix? Fixes #
    Fixes Android builds. Same solution can be used in the future for any cross-platform builds.

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    x64-Android

  • Does your PR follow the maintainer guide?
    Yes

(cherry picked from commit 55b2c4c)
(cherry picked from commit dc28ba7)
@JackBoosY JackBoosY added category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-bug The issue is with a library, which is something the port should already support labels Jan 18, 2021
@NancyLi1013
Copy link
Contributor

Hi @ahmedyarub

Could you please execute the command vcpkg x-add-version aws-sdk-cpp first?

Found the following errors:
Error: While reading versions for port aws-sdk-cpp from file: C:\a\1\s\port_versions\a-\aws-sdk-cpp.json
       File declares version `1.8.83#5` with SHA: 471e4ba73dcb43a31ebd0c460b298fb38b1f5625
       But local port with the same verion has a different SHA: bfc729671845a82f9c592a234f0daeacdde8daea
       Please update the port's version fields and then run:

           vcpkg x-add-version aws-sdk-cpp

Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you updated many formats, which are not related with your changes. Could you please revert these?

@ahmedyarub
Copy link
Contributor Author

I think that I'll be creating a new PR. For some reason Windows + CLion cannot detect the formatting changes!

@ahmedyarub
Copy link
Contributor Author

Superseded by #15725

@ahmedyarub ahmedyarub closed this Jan 18, 2021
@ahmedyarub ahmedyarub deleted the fix_aws_android branch January 18, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants