Closed
Conversation
Contributor
|
Hi @ahmedyarub Could you please execute the command |
NancyLi1013
reviewed
Jan 18, 2021
Contributor
NancyLi1013
left a comment
There was a problem hiding this comment.
It seems like you updated many formats, which are not related with your changes. Could you please revert these?
Contributor
Author
|
I think that I'll be creating a new PR. For some reason Windows + CLion cannot detect the formatting changes! |
Contributor
Author
|
Superseded by #15725 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Adds toolchain chaining to external builds
What does your PR fix? Fixes #
Fixes Android builds. Same solution can be used in the future for any cross-platform builds.
Which triplets are supported/not supported? Have you updated the CI baseline?
x64-Android
Does your PR follow the maintainer guide?
Yes