Skip to content

[opencv4] update from 4.3.0 to 4.5.1#15607

Closed
ludchieng wants to merge 2 commits intomicrosoft:masterfrom
ludchieng:opencv-update-to-4.5.1
Closed

[opencv4] update from 4.3.0 to 4.5.1#15607
ludchieng wants to merge 2 commits intomicrosoft:masterfrom
ludchieng:opencv-update-to-4.5.1

Conversation

@ludchieng
Copy link
Copy Markdown
Contributor

  • What does your PR fix?

Update opencv 4.3.0 to 4.5.1
Gives access to new opencv contrib modules

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Tested on x64-windows

Yes, we tried

[Draft] There are two remaining problems:

  • We commented patches for opencv 4.3.0 in the portfile.cmake as we don't know how to update them for 4.5.1
  • OpenCVModules.cmake is now installed in "installed/x64-windows/share/opencv/x64/vc16/lib" instead of "installed/x64-windows/share/opencv". As _IMPORT_PREFIX variable is based on this relative path, cmake fails to find the librairies files.

@ghost
Copy link
Copy Markdown

ghost commented Jan 12, 2021

CLA assistant check
All CLA requirements met.

@JonLiu1993 JonLiu1993 self-assigned this Jan 13, 2021
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jan 13, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

cc @Neumann-A @cenit for review this PR.

@cenit
Copy link
Copy Markdown
Contributor

cenit commented Jan 13, 2021

nope, this pr is not valid. It does not even bother to disable automatic download of packages...

@fabiencastan
Copy link
Copy Markdown
Contributor

The PR has been created in DRAFT and explicitely says that it is not ready. There are 2 issues:

  • patches needs to be upgraded
  • OpenCVModules.cmake needs to be fixed due to changes in opencv cmake files.

Could someone with an experience on this package help us or guide us to make the upgrade?

@fabiencastan
Copy link
Copy Markdown
Contributor

An update to 4.5 has already been started in #15162.

@ludchieng ludchieng closed this Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants