[boost-locale] android build#15606
Merged
dan-shaw merged 18 commits intomicrosoft:masterfrom Jan 25, 2021
Merged
Conversation
JackBoosY
added
the
category:port-feature
Contributor
|
The gdal:x86-windows failed due to known issue #15324. it doesn't block this PR. |
PhoebeHui
approved these changes
Jan 13, 2021
Contributor
PhoebeHui
left a comment
PhoebeHui
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR!
PhoebeHui
added
the
info:needs-maintainer-attention
Contributor
|
@xandox, could you resolve the conflicts? We need additional steps to fix the CI failures, we added new CI check features to vcpkg, see PR#15655.
|
PhoebeHui
added
requires:author-response
and removed
info:needs-maintainer-attention
added 4 commits
January 15, 2021 11:53
Contributor
Author
|
@PhoebeHui can you review and rerun checks, fails look like not related to this changes. |
Contributor
|
@xandox, please ignore the CI failures, I can't repro the issue locally, I have rerun the CI test. |
PhoebeHui
added
info:needs-maintainer-attention
dan-shaw
reviewed
Jan 20, 2021
| boost.locale.icu=${BOOST_LOCALE_ICU_FEATURE} | ||
| -sICONV_PATH=${LIBICONV_DIR} | ||
| ) | ||
| if(VCPKG_CMAKE_SYSTEM_NAME STREQUAL "Emscripten" OR VCPKG_TARGET_ARCHITECTURE STREQUAL "wasm32") |
Contributor
There was a problem hiding this comment.
Can this logic be removed? I don't think it applies to Android.
dan-shaw
added
requires:author-response
and removed
info:needs-maintainer-attention
added 2 commits
January 21, 2021 12:12
PhoebeHui
approved these changes
Jan 22, 2021
PhoebeHui
added
the
info:needs-maintainer-attention
dan-shaw
approved these changes
Jan 23, 2021
Contributor
|
@xandox @PhoebeHui Can you resolve the conflict? Otherwise LGTM. |
Contributor
Author
|
@PhoebeHui thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
building boost-locale for android
Which triplets are supported/not supported? mostly android
Have you updated the CI baseline? no
Does your PR follow the maintainer guide? yes