[pangolin] Fix static build error#15593
Merged
ras0219-msft merged 5 commits intomicrosoft:masterfrom Mar 11, 2021
Merged
Conversation
NancyLi1013
added
category:port-bug
JackBoosY
suggested changes
Jan 12, 2021
added 2 commits
February 26, 2021 00:10
…NancyLi/fix-pangolin # Conflicts: # ports/ffmpeg/CONTROL
JackBoosY
approved these changes
Mar 10, 2021
JackBoosY
added
the
info:needs-maintainer-attention
vicroms
approved these changes
Mar 10, 2021
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Use
ffmpegprovied by vcpkg inpangolin.Add
cmake_policy(SET CMP0012 NEW)in vcpkg-cmake-wrapper.cmake forffmpegto avoidif()calls fail, causing the feature dependencies not found.