[vcpkg] Add changelog generator#15271
Conversation
|
Is it possible to put the credentials in an environment variable to avoid being prompted every time? |
I thought about this a bit and explored getting cached credentials out of the git credential manager, or by possibly reading a git-credential file or environment variable. It seems that the git credentials cache doesn't expose the cached passwords. Understandably it's kept in memory and not exposed. Reading a git credential file is definitely possible, but I don't see any existing utilities for that. I can try to parse a credential file, but that means adding a parameter set to the options, validating the file, and then manually parsing for the correct credentials. The other point is that keeping your credentials stored in a plain text file (e.g. via Reading an environment variable is just about as bad as reading a plaintext file (depending who you ask), so I think the final conclusion is to make the facility password-storage agnostic. My recommendation is to create a PS C:\source\vcpkg> $cred = Get-Credential
cmdlet Get-Credential at command pipeline position 1
Supply values for the following parameters:
Credential
PS C:\source\vcpkg> .\scripts\Get-Changelog.ps1 -Credentials $cred
|
|
Added:
That'll be about it for this PR. @vicroms feel free to merge when ready 🙂 |
strega-nil
left a comment
There was a problem hiding this comment.
You should also change the rest of the file in a similar way; @grdowns are you willing to continue this PR? or should I take it over?
|
Thanks for the feedback! I'll get to this soon; let's wait to merge until then. |
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
|
@strega-nil I committed your changes and fixed a couple things as fallout from the changes (see latest commit). This should be ready to merge upon your review. 🙂 |
|
Ping @strega-nil @strega-nil-ms for review this PR. |
|
I have some changes to clean and push to this PR, I'll try to find some time this week to finally get this merged! |
|
@vicroms, any updates? |
|
I'm closing this for now. @vicroms Please reopen if you want to continue. |
|
What was in this PR needed sufficient additional work that I now believe it fair to start another PR. |
Here's the changelog generator used for the release notes, now ported to PowerShell. I've tested this on arbitrary date ranges, and it seems to work well.
You can use this yourself by running the script
.\Get-Changelog.ps1, where it will prompt you for a date range and credentials. There's no logging on it at the moment, so expect to be twiddling your thumbs for a minute or so while it works.