[speexdsp] Fix include directories for Linux builds#15036
Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom Dec 10, 2020
Merged
[speexdsp] Fix include directories for Linux builds#15036BillyONeal merged 2 commits intomicrosoft:masterfrom
BillyONeal merged 2 commits intomicrosoft:masterfrom
Conversation
JackBoosY
added
the
category:port-bug
JackBoosY
approved these changes
Dec 10, 2020
Member
|
Thanks so much for your help! |
Member
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the comments of #14758, @BillyONeal pointed out there was a build error when compiling on Linux. As it turns out, when I was dealing with an error in the CI tests (that wasn't appearing for me locally), I changed the location where the configured header file
speexdsp_config_types.hgets written to before installing, but forgot to add the new location to the project's include directories. This is a quick fix for that mistake that fixes the Linux build (I tested it in Docker).