Skip to content

[aws-sdk-cpp] Add find_dependency to AWSSDKConfig.cmake and fix usage#14936

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/aws-sdk-cpp-find-dependency
Dec 5, 2020
Merged

[aws-sdk-cpp] Add find_dependency to AWSSDKConfig.cmake and fix usage#14936
BillyONeal merged 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/aws-sdk-cpp-find-dependency

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

  • The AWSSDKConfig.cmake dependency provided by the upstream lacks find_dependency. Add it.
  • AWSSDKConfig.cmake should be used as the main entry point.

Fixes #7373 (comment)

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Dec 4, 2020
@JackBoosY JackBoosY requested a review from NancyLi1013 December 4, 2020 07:10
@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 4, 2020
@BillyONeal BillyONeal merged commit 87a908d into microsoft:master Dec 5, 2020
@BillyONeal
Copy link
Copy Markdown
Member

Thanks!

@JackBoosY JackBoosY deleted the dev/jack/aws-sdk-cpp-find-dependency branch December 7, 2020 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[curl] x64-linux debug build links against release version of the lib

3 participants