Skip to content

[usockets] Fix build issue with feature ssl#14935

Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/usockets
Dec 5, 2020
Merged

[usockets] Fix build issue with feature ssl#14935
BillyONeal merged 3 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/usockets

Conversation

@PhoebeHui
Copy link
Copy Markdown
Contributor

@PhoebeHui PhoebeHui commented Dec 4, 2020

Fixes #14933

sni* are in sni_tree.cpp, which not built in vcpkg, including this file, and it requires c++17 or later. See https://github.com/uNetworking/uSockets/blob/master/Makefile#L43

All features test pass with x64-windows and x64-windows-static

Failures:

openssl.c.obj : error LNK2019: unresolved external symbol _sni_new referenced in function _us_internal_create_ssl_socket_context
openssl.c.obj : error LNK2019: unresolved external symbol _sni_free referenced in function _us_internal_ssl_socket_context_free
openssl.c.obj : error LNK2019: unresolved external symbol _sni_add referenced in function _us_internal_ssl_socket_context_add_server_name
openssl.c.obj : error LNK2019: unresolved external symbol _sni_remove referenced in function _us_internal_ssl_socket_context_remove_server_name
openssl.c.obj : error LNK2019: unresolved external symbol _sni_find referenced in function _resolve_context
uSockets.dll : fatal error LNK1120: 5 unresolved externals

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Dec 4, 2020
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 4, 2020
@BillyONeal BillyONeal merged commit de70813 into microsoft:master Dec 5, 2020
@BillyONeal
Copy link
Copy Markdown
Member

Thanks for your help!

@PhoebeHui PhoebeHui deleted the dev/Phoebe/usockets branch June 17, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uSockets[ssl] build failure

3 participants