[opencascade] Fix static build#14901
Merged
BillyONeal merged 7 commits intomicrosoft:masterfrom Dec 5, 2020
Merged
Conversation
Contributor
Author
|
@fauder Can you test this PR? Thanks. |
Thank you for taking the time to fix this. What I did:
Build failed unfortunately: |
marekr
reviewed
Dec 2, 2020
|
Pulled f58bacb and tried again and got errors: |
Contributor
Author
|
@fauder I will ping you when I finish this PR. |
Sure. |
Contributor
Author
|
@fauder Ready |
JackBoosY
commented
Dec 4, 2020
JackBoosY
commented
Dec 4, 2020
| #include <stdlib.h> | ||
|
|
||
| - #ifdef _MSC_VER | ||
| - #pragma comment (lib, "freetype.lib") |
Contributor
Author
There was a problem hiding this comment.
Already set to link in cmake.
PhoebeHui
approved these changes
Dec 4, 2020
It builds without any errors on a fresh vcpkg clone 👍 I'll wait for it to be merged to try it on my actual vcpkg directory. It took 40 minutes sheesh. Thanks a lot by the way. |
Member
|
Thanks for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14874.
Already tested all features in
x64-windowsandx64-windows-staticsuccessfully.