[vcpkg] Add SemVer and Date versioning schemes#14889
Merged
vicroms merged 16 commits intomicrosoft:masterfrom Dec 7, 2020
Merged
[vcpkg] Add SemVer and Date versioning schemes#14889vicroms merged 16 commits intomicrosoft:masterfrom
vicroms merged 16 commits intomicrosoft:masterfrom
Conversation
ras0219
reviewed
Dec 3, 2020
ras0219
approved these changes
Dec 5, 2020
ras0219
suggested changes
Dec 5, 2020
BillyONeal
reviewed
Dec 6, 2020
ras0219
approved these changes
Dec 6, 2020
Contributor
ras0219
left a comment
There was a problem hiding this comment.
LGTM once @BillyONeal's comment about locale is addressed.
BillyONeal
approved these changes
Dec 7, 2020
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* [vcpkg] Add semver versioning scheme * Remove unnecessary code * Fix SemVer comparison and add sorting test * Add date scheme * PR comments * Use a different column for date and semver schemes. * Use locale agnostic conversion to long * Add tests for version scheme change * Validate version strings before parsing * Format * Improve error messages * PR comments * PR comments pt. 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vcpkg is now able to understand
version-dateandversion-semverReference #11758