Skip to content

[aws-sdk-cpp] Restore AWSSDKConfig.cmake and add usage#14868

Merged
strega-nil merged 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/14817
Dec 2, 2020
Merged

[aws-sdk-cpp] Restore AWSSDKConfig.cmake and add usage#14868
strega-nil merged 1 commit intomicrosoft:masterfrom
JackBoosY:dev/jack/14817

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY commented Dec 1, 2020

  • Don't remove AWSSDKConfig.cmake
  • Fix AWSSDKConfig.cmake
  • Add usage, because vcpkg cannot analyze cmake files correctly

Fixes #14817.

Already test the usage locally.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Dec 1, 2020
@JackBoosY JackBoosY requested a review from PhoebeHui December 1, 2020 08:10
@kszucs
Copy link
Copy Markdown

kszucs commented Dec 1, 2020

Thanks for the quick patch!

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 2, 2020
@strega-nil strega-nil merged commit ad36a4f into microsoft:master Dec 2, 2020
@strega-nil
Copy link
Copy Markdown
Contributor

Thanks @JackBoosY :)

@JackBoosY JackBoosY deleted the dev/jack/14817 branch December 3, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aws-sdk-cpp] Missing AWSSDKConfig.cmake

5 participants