Change Nuget binary cache pre-release info to always start with letters#14857
Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom Dec 4, 2020
frivard-coveo:bug/vcpkg-14542-buildmetadata
Merged
Change Nuget binary cache pre-release info to always start with letters#14857BillyONeal merged 3 commits intomicrosoft:masterfrom frivard-coveo:bug/vcpkg-14542-buildmetadata
BillyONeal merged 3 commits intomicrosoft:masterfrom
frivard-coveo:bug/vcpkg-14542-buildmetadata
Conversation
|
|
frivard-coveo
changed the title
Contributor
Author
|
After some testing, dropping the pre-release information alters the filename, which causes more problems since the filename, which is used directly for a search on the nuget source, no longer contains any abi info. |
Contributor
|
cc @ras0219 |
ras0219
approved these changes
Dec 1, 2020
Contributor
Author
|
The failing check is for port which is not related to my PR. Is it possible that it was already broken? |
JackBoosY
added
category:vcpkg-feature
Member
|
Thanks for your contribution! |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix? Fixes When uploading to Nuget, the SemVer version might be invalid #14542
Which triplets are supported/not supported? Have you updated the CI baseline? Not applicable, this PR affects the "tool" vcpkg.exe
Does your PR follow the maintainer guide? Yes. I ran the full test suite and everything passes.