[Chipmunk] build via cmake#14776
Merged
BillyONeal merged 5 commits intomicrosoft:masterfrom Dec 4, 2020
Merged
Conversation
NancyLi1013
added
the
category:port-feature
NancyLi1013
suggested changes
Nov 26, 2020
Contributor
NancyLi1013
left a comment
NancyLi1013
left a comment
There was a problem hiding this comment.
You might try to remove msbuild part and verify if it can build fine on Windows via CMake.
Contributor
|
Please also update version in |
Contributor
Author
|
@NancyLi1013 changes made. |
Contributor
Have you tried to build via CMake on all platforms? |
Back ARM builds to baseline
Contributor
Author
Yeah, tested and fixed for x64 UWP |
NancyLi1013
suggested changes
Dec 2, 2020
Kept consistent on portfile
NancyLi1013
approved these changes
Dec 3, 2020
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
added
the
info:needs-maintainer-attention
Contributor
|
LGTm now, thanks for your PR @comedinha. |
Member
|
Awesome, thanks for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually the chipmunk only can build via msvc, this change will allow build via cmake.
What does your PR fix? Fixes #
[chipmunk] add support for Linux #10802
Which triplets are supported/not supported? Have you updated the CI baseline?
I tested on windows x64 and mingw-w64-static.
Does your PR follow the maintainer guide?
Yes