Skip to content

[azure-kinect-sensor-sdk] not working on Linux#14750

Merged
vicroms merged 8 commits intomicrosoft:masterfrom
fran6co:azure_linux
Mar 29, 2021
Merged

[azure-kinect-sensor-sdk] not working on Linux#14750
vicroms merged 8 commits intomicrosoft:masterfrom
fran6co:azure_linux

Conversation

@fran6co
Copy link
Contributor

@fran6co fran6co commented Nov 24, 2020

Depends on #14749

Fixes #12995

@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 25, 2020
@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Nov 26, 2020
@fran6co fran6co force-pushed the azure_linux branch 12 times, most recently from a76a9f0 to 0129bfe Compare February 8, 2021 15:49
@fran6co fran6co requested a review from JackBoosY February 8, 2021 16:23
@JackBoosY
Copy link
Contributor

JackBoosY commented Feb 9, 2021

Sorry but you may need to revert libuvc changes after #14749 merged.

@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Feb 9, 2021
@JackBoosY
Copy link
Contributor

As I said, please revert changes about libuvc.

Thanks.

  - linux: warnings stopping the build
  - linux: set correct casing for dependecies
  - linux: depthengine
  - upgrade to 1.4.1
@fran6co
Copy link
Contributor Author

fran6co commented Feb 9, 2021

@JackBoosY done

@JackBoosY
Copy link
Contributor

Waiting for merge #16138.

@JackBoosY JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Feb 9, 2021
@JackBoosY
Copy link
Contributor

JackBoosY commented Feb 22, 2021

When building x64-osx:

CMake Error at /Volumes/data/work/1/s/scripts/buildsystems/vcpkg.cmake:857 (_find_package):
  Could not find a package configuration file provided by "libuvc" with any
  of the following names:

    libuvcConfig.cmake
    libuvc-config.cmake

  Add the installation prefix of "libuvc" to CMAKE_PREFIX_PATH or set
  "libuvc_DIR" to a directory containing one of the above files.  If "libuvc"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  CMakeLists.txt:114 (find_package)

Is that expected?

@fran6co
Copy link
Contributor Author

fran6co commented Feb 22, 2021

@JackBoosY yes, I didn't get libuvc to build on macOS so it's only available for Linux right now. Probably it's easy to fix it, but I think it would be better to make this port only support windows and Linux for now.

@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Feb 22, 2021
@adammpolak
Copy link

@fran6co is this PR ready to rock?

@fran6co
Copy link
Contributor Author

fran6co commented Mar 9, 2021

Not sure about rocking but maybe you can get some jazz out of it

@JackBoosY
Copy link
Contributor

Waiting for merge.

@adammpolak
Copy link

( @JackBoosY how do we merge 😬)

@ras0219-msft
Copy link
Contributor

I've pushed the merge to https://github.com/ras0219-msft/vcpkg/tree/azure_linux, however I'm unable to push directly to your branch. Could you please run:

git pull https://github.com/ras0219-msft/vcpkg azure_linux
git push

while on your azure_linux branch?

@JackBoosY JackBoosY added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Mar 16, 2021
@fran6co
Copy link
Contributor Author

fran6co commented Mar 16, 2021

@ras0219-msft done

@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Mar 16, 2021
@vicroms vicroms merged commit 5eae23f into microsoft:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[azure-kinect-sensor-sdk] build failure

5 participants