[duktape] Add VERSION and SOVERSION properties CMake build#14666
Merged
strega-nil merged 1 commit intomicrosoft:masterfrom Nov 25, 2020
Merged
[duktape] Add VERSION and SOVERSION properties CMake build#14666strega-nil merged 1 commit intomicrosoft:masterfrom
strega-nil merged 1 commit intomicrosoft:masterfrom
Conversation
5 tasks
NancyLi1013
changed the title
NancyLi1013
added
the
category:port-feature
NancyLi1013
reviewed
Nov 20, 2020
Contributor
NancyLi1013
left a comment
NancyLi1013
left a comment
There was a problem hiding this comment.
Could you please also add Port-Version to the CONTROL file?
LRFLEW
force-pushed
the
duktape-soversion
branch
from
eb38f76 to
d60eba0
Compare
NancyLi1013
approved these changes
Nov 25, 2020
NancyLi1013
added
info:needs-maintainer-attention
Contributor
|
LGTM, thanks @LRFLEW |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fairly simple change that should have minimal impact. The biggest change is that it will add the version numbers to the dynamic libraries built for macOS and Linux using custom or community triplets. The
SOVERSIONis set to the major version, as the project's semantic versioning indicates this is the API compatibility value.