Use OS-included Python 2.7 on macOS#14662
Merged
strega-nil merged 1 commit intomicrosoft:masterfrom Nov 24, 2020
Merged
Conversation
5 tasks
ras0219
approved these changes
Nov 20, 2020
Contributor
ras0219
left a comment
There was a problem hiding this comment.
LGTM; could you also consider adding a message to duktape about it's pyyaml dependency? Something like
if(CMAKE_HOST_SYSTEM_NAME STREQUAL "Darwin")
message(STATUS "Duktape requires pyyaml to build -- this is available with `easy_install pyyaml`")
endif()
or somesuch
Contributor
Author
|
I was planning on making an issue for the pyyaml duktape issue once this was merged. (I was trying to keep this change in the tooling separate from the changes in the port). There seems to be some complexity to it, because the fix could be changing |
JackBoosY
approved these changes
Nov 23, 2020
Contributor
|
@LRFLEW thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes building
duktape*, as well as other ports that depend on python2 (I haven't done a full scan for what else would be included). I didn't find a Github issue for this, but it does relate to PR #10030.This updates
vcpkg_find_acquire_program(PYTHON2)to changePROGNAMEfrompython2topythonon macOS. Apple includes Python 2.7 under this name, but not aspython2, in all (supported) OS releases. It is deprecated, but it is included in 11.0 Big Sur from what I've read, and because Python 2 was removed from Homebrew, this will allow it to work for now at least.*
duktapestill has a minor issue caused byeasy_installneeding to be executed as root, but installingpyyamlahead of time allows the build to succeed, even witheasy_installfailing.