[mesa] new port by Neumann-A · Pull Request #14640 · microsoft/vcpkg

Neumann-A · 2020-11-18T23:06:03Z

should currently only work for windows. (Since CI on other platforms are currently probably missing dependencies)

PhoebeHui · 2020-11-20T06:22:05Z

CI test failures:

..\src\189b5861b5-bd40f385ca.clean\meson.build:1492:2: ERROR: Neither a subproject directory nor a llvm.wrap file was found.

Full logs:
failure logs for x86-windows.zip

PhoebeHui · 2020-11-23T09:35:43Z

/azp run

azure-pipelines · 2020-11-23T09:35:57Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoebeHui · 2020-11-27T05:44:46Z

@Neumann-A, here is failure for libass:x64-linux in CI testing:

/mnt/vcpkg-ci/buildtrees/libass/src/ebd911d5ca-39016ec3fc.clean/libass/ass_fontconfig.c:26:10: fatal error: fontconfig/fontconfig.h: No such file or directory
 #include <fontconfig/fontconfig.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~

failure logs for x64-linux (9).zip

Neumann-A · 2020-11-27T08:41:02Z

@PhoebeHui that seems to be unrelated to this PR since the depend-info for libass does not list fontconfig!

$ ./vcpkg.exe depend-info libass
zlib:
brotli:
bzip2:
libpng: zlib
freetype[bzip2, png]: brotli, bzip2, libpng, zlib
ragel:
tool-meson:
dirent:
fribidi: tool-meson
harfbuzz: freetype, ragel
libass: dirent, freetype, fribidi, harfbuzz

also applies to x64-linux
$ ./vcpkg.exe depend-info libass:x64-linux
zlib:
brotli:
bzip2:
libpng: zlib
freetype[bzip2, png]: brotli, bzip2, libpng, zlib
ragel:
tool-meson:
fribidi: tool-meson
harfbuzz: freetype, ragel
libass: freetype, fribidi, harfbuzz

looking at the CMakeLists.txt it vendored by vcpkg it is definitely missing a find_package(Fontconfig) and a Build-Depends on it.

Since it is completely unrelated I am not going to fix it in this PR.

PhoebeHui · 2020-11-27T09:37:20Z

@Neumann-A, please ignore it, it's not related to this changes, it also failed in master, I will take a look the baseline issue.

PhoebeHui · 2020-11-27T09:38:54Z

I will test all features with x64-window if you haven't test yet.

Neumann-A · 2020-11-27T10:18:18Z

@PhoebeHui. I did not test everything. One interesting point will be if llvm[core] is really enough or if llvm[core,target-x64] is required. I couldn't really deduce that from mesa's find_dep call.

PhoebeHui · 2020-12-01T02:23:34Z

Feature 'egl' test failed with x64-windows, others passed.

..\src\189b5861b5-bd40f385ca.clean\meson.build:412:4: ERROR: Problem encountered: EGL requires dri

meson-log.txt

Neumann-A · 2020-12-01T09:02:43Z

That feature probably only works for unix due to:

  elif ['darwin', 'windows'].contains(host_machine.system())
    error('EGL is not available on Windows or MacOS')

PhoebeHui · 2020-12-01T10:34:19Z

Could you add comments to portfile.cmake or description in CONTROL file about the failed feature 'egl'?

strega-nil · 2021-01-07T18:03:19Z

Adding requires:discussion to talk about at the mtg today.

BillyONeal · 2021-01-07T22:09:52Z

ports/mesa/CONTROL

+Build-Depends: mesa[core]
+
+Feature: opengl
+Description: Build support for OpenGL (all versions)


Suggested change

Description: Build support for OpenGL (all versions)

Description: Build support for OpenGL (all non-ES versions)

The description is from meson_options.txt stating:

option( 'opengl', type : 'boolean', value : true, description : 'Build support for OpenGL (all versions)' )

I think features in vcpkg should copy upstream descriptions 1:1 even if it seems to be a wrong.

strega-nil · 2021-01-07T22:11:04Z

@Neumann-A is there a reason that we don't just always build shared-glapi?

Neumann-A · 2021-01-07T22:29:44Z

is there a reason that we don't just always build shared-glapi?

The only discussion I found is in https://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg17040.html and there seem to be at least one use case which does not use a shared-glapi

strega-nil · 2021-01-07T22:33:10Z

@Neumann-A hmm, it looks to me like unshared-glapi is pretty not-useful, except for maybe some minor cases to do with system package managers. I think the best thing to do is just make shared-glapi always-on, and if a person really needs unshared-glapi, they can work on it themselves.

ports/mesa/portfile.cmake

ras0219-msft · 2021-01-08T01:02:54Z

ports/mesa/portfile.cmake

+file(REMOVE ${CURRENT_PACKAGES_DIR}/include/EGL/eglext.h)
+file(REMOVE ${CURRENT_PACKAGES_DIR}/include/EGL/eglplatform.h)
+
+#installed by opengl-registry


Should this port depend on opengl-registry then?

this would only generate an hard error on the installation of mesa if it tries to install headers which are already present, The build itself will not use either egl-registry nor opengl-registry.

ras0219-msft · 2021-01-08T01:07:04Z

ports/mesa/portfile.cmake

+foreach(_file ${_double_files})
+    if(EXISTS "${CURRENT_PACKAGES_DIR}/${_file}")
+        file(REMOVE "${CURRENT_PACKAGES_DIR}/${_file}")
+    endif()
+endforeach()


Suggested change

foreach(_file ${_double_files})

if(EXISTS "${CURRENT_PACKAGES_DIR}/${_file}")

file(REMOVE "${CURRENT_PACKAGES_DIR}/${_file}")

endif()

endforeach()

list(TRANSFORM _double_files PREPEND "${CURRENT_PACKAGES_DIR}/")

file(REMOVE ${_double_files})

ras0219-msft · 2021-01-08T01:09:06Z

ports/mesa/portfile.cmake

+set(_double_files include/GL/glcorearb.h include/GL/glext.h include/GL/glxext.h 
+    include/GLES/egl.h include/GLES/gl.h include/GLES/glext.h include/GLES/glplatform.h 
+    include/GLES2/gl2.h include/GLES2/gl2ext.h include/GLES2/gl2platform.h
+    include/GLES3/gl3.h  include/GLES3/gl31.h include/GLES3/gl32.h include/GLES3/gl3platform.h)


Suggested change

set(_double_files include/GL/glcorearb.h include/GL/glext.h include/GL/glxext.h

include/GLES/egl.h include/GLES/gl.h include/GLES/glext.h include/GLES/glplatform.h

include/GLES2/gl2.h include/GLES2/gl2ext.h include/GLES2/gl2platform.h

include/GLES3/gl3.h include/GLES3/gl31.h include/GLES3/gl32.h include/GLES3/gl3platform.h)

set(_double_files include/GL/glcorearb.h include/GL/glext.h include/GL/glxext.h

include/GLES3/gl3.h include/GLES3/gl31.h include/GLES3/gl32.h include/GLES3/gl3platform.h)

Below is already removing the GLES and GLES2 dirs.

… and parts being a dynamic library.

PhoebeHui · 2021-01-11T03:05:50Z

The x64-windows-static failed with 'only supports dynamic crt linkage", @Neumann-A, could you add mesa:x64-windows-static to ci.baseline file for unblocking CI testing?

CMake Error at scripts/cmake/vcpkg_check_linkage.cmake:51 (message):
  mesa only supports dynamic crt linkage
Call Stack (most recent call first):
  ports/mesa/portfile.cmake:10 (vcpkg_check_linkage)
  scripts/ports.cmake:136 (include)

Neumann-A · 2021-01-11T08:12:25Z

ports/mesa/portfile.cmake

+vcpkg_add_to_path("${PYTHON3_DIR}/Scripts")
+set(ENV{PYTHON} "${PYTHON3}")
+
+function(vcpkg_get_python_package PYTHON_DIR )


@ras0219-msft As requested I factored out a function called vcpkg_get_python_package here but I did not put it into scripts/cmake yet since I did not want to rebuild all ports within this PR.

[mesa] new port

ade3a2d

NancyLi1013 assigned PhoebeHui Nov 19, 2020

NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Nov 19, 2020

Neumann-A and others added 3 commits November 19, 2020 16:57

make mesa build more.

2bc3094

Merge remote-tracking branch 'upstream/master' into mesa

633b976

more fine tuning

6a9dda4

Neumann-A added 2 commits November 20, 2020 09:59

fix x86

f2e7f02

add supports.

37dba81

Neumann-A marked this pull request as ready for review November 20, 2020 09:41

PhoebeHui added the requires:all-feature-testing label Nov 24, 2020

PhoebeHui added the requires:author-response label Nov 27, 2020

PhoebeHui removed the requires:author-response label Nov 27, 2020

PhoebeHui mentioned this pull request Nov 30, 2020

[vcpkg baseline] [libass] Fix dependency issue in Linux #14843

Merged

PhoebeHui added the requires:author-response label Dec 1, 2020

Neumann-A and others added 4 commits December 1, 2020 11:42

comment about EGL feature.

1e1be84

Resolve conficts

2fa61e6

Resolve conflicts

e8bcd47

Merge branch 'mesa' of https://github.com/Neumann-A/vcpkg into mesa

dc0ebea

PhoebeHui removed the requires:all-feature-testing label Dec 2, 2020

strega-nil added the requires:discussion label Jan 7, 2021

strega-nil self-requested a review January 7, 2021 18:03

strega-nil approved these changes Jan 7, 2021

View reviewed changes

BillyONeal reviewed Jan 7, 2021

View reviewed changes

strega-nil added requires:author-response and removed requires:discussion labels Jan 7, 2021

make sharedgl-api=true the hardcoded default

75d1fb3

strega-nil approved these changes Jan 7, 2021

View reviewed changes

strega-nil added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Jan 7, 2021

ras0219-msft requested changes Jan 8, 2021

View reviewed changes

Neumann-A and others added 2 commits January 8, 2021 12:00

add suggestion from CR

f2176c5

add mesa:x64-windows-static=fail to ci.baseline.txt due to static crt…

df3047c

… and parts being a dynamic library.

PhoebeHui added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Jan 11, 2021

apply CR sugesstion

03d2ebe

Neumann-A commented Jan 11, 2021

View reviewed changes

PhoebeHui removed the requires:author-response label Jan 11, 2021

PhoebeHui requested a review from ras0219-msft January 11, 2021 09:52

vicroms approved these changes Jan 12, 2021

View reviewed changes

vicroms merged commit 9c63f97 into microsoft:master Jan 12, 2021

Neumann-A deleted the mesa branch January 12, 2021 06:30

PhoebeHui mentioned this pull request Jun 25, 2021

[llvm] update to 12.0.0, enable zlib and libxml2 #17302

Merged

WangWeiLin-MV mentioned this pull request Jul 9, 2024

[mesa] Build failure on arm64-osx #39782

Open

	Description: Build support for OpenGL (all versions)
	Description: Build support for OpenGL (all non-ES versions)

Conversation

Neumann-A commented Nov 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PhoebeHui commented Nov 20, 2020

Uh oh!

PhoebeHui commented Nov 23, 2020

Uh oh!

azure-pipelines bot commented Nov 23, 2020

Uh oh!

PhoebeHui commented Nov 27, 2020

Uh oh!

Neumann-A commented Nov 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PhoebeHui commented Nov 27, 2020

Uh oh!

PhoebeHui commented Nov 27, 2020

Uh oh!

Neumann-A commented Nov 27, 2020

Uh oh!

PhoebeHui commented Dec 1, 2020

Uh oh!

Neumann-A commented Dec 1, 2020

Uh oh!

PhoebeHui commented Dec 1, 2020

Uh oh!

strega-nil commented Jan 7, 2021

Uh oh!

BillyONeal Jan 7, 2021

Choose a reason for hiding this comment

Uh oh!

Neumann-A Jan 7, 2021

Choose a reason for hiding this comment

Uh oh!

strega-nil commented Jan 7, 2021

Uh oh!

Neumann-A commented Jan 7, 2021

Uh oh!

strega-nil commented Jan 7, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ras0219-msft Jan 8, 2021

Choose a reason for hiding this comment

Uh oh!

Neumann-A Jan 11, 2021

Choose a reason for hiding this comment

Uh oh!

ras0219-msft Jan 8, 2021

Choose a reason for hiding this comment

Uh oh!

ras0219-msft Jan 8, 2021

Choose a reason for hiding this comment

Uh oh!

PhoebeHui commented Jan 11, 2021

Uh oh!

Neumann-A Jan 11, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Neumann-A commented Nov 18, 2020 •

edited

Loading

Neumann-A commented Nov 27, 2020 •

edited

Loading