[many ports] mingw support by longnguyen2004 · Pull Request #14556 · microsoft/vcpkg

longnguyen2004 · 2020-11-13T10:25:56Z

Describe the pull request

What does your PR fix?
Add mingw support for a bunch of ffmpeg related ports
~~Currently testing ffmpeg with features [avcodec,avdevice,avfilter,avformat,avresample,bzip2,core,ffmpeg,ffprobe,gpl,lzma,mp3lame,opus,postproc,swresample,swscale,theora,vorbis,vpx,x264,x265,zlib]~~ Works perfectly now.
Which triplets are supported/not supported? Have you updated the CI baseline?
All mingw triplets
Does your PR follow the maintainer guide?
Yes

…ables

ports/mp3lame/portfile.cmake

Co-authored-by: Matthias C. M. Troffaes <matthias.troffaes@gmail.com>

…004/vcpkg into mingw-ffmpeg-related

ports/libvpx/portfile.cmake

longnguyen2004 · 2020-11-14T03:28:38Z

Seems to work fine! I think this is ready

NancyLi1013

Could you please also update Port-Version for libogg?

longnguyen2004 · 2020-11-16T08:16:27Z

Sure I'll amend that commit tonight

NancyLi1013 · 2020-11-17T06:18:28Z

/azp run

azure-pipelines · 2020-11-17T06:18:37Z

Azure Pipelines successfully started running 1 pipeline(s).

JackBoosY · 2020-11-24T06:31:57Z

gdal:x64-osx regression:

jpeg2000_vsil_io.cpp:151:5: error: cannot initialize a member subobject of type 'int (*)(jas_stream_obj_t *, const char *, unsigned int)' (aka 'int (*)(void *, const char *, unsigned int)') with an lvalue of type 'int (jas_stream_obj_t *, char *, unsigned int)' (aka 'int (void *, char *, unsigned int)'): type mismatch at 2nd parameter ('const char *' vs 'char *')
    JPEG2000_VSIL_write,
    ^~~~~~~~~~~~~~~~~~~
1 error generated.

longnguyen2004 · 2020-11-24T07:54:15Z

Every changes made to vcpkg_configure_make results in a huge conflict for whatever reason, does anyone know why?
Also, the gdal regression doesn't seem to come from me.

JackBoosY · 2020-11-24T08:21:51Z

@longnguyen2004 I updated vcpkg_configure_make in my another PR some days ago.

Neumann-A · 2020-11-24T08:37:37Z

huge conflict for whatever reason, does anyone know why?

I just don't like the WS changes to it.

your line endings probably are wrong and that is why your PR is updating all of the file.

longnguyen2004 · 2020-11-24T10:11:08Z

Hmm I haven't done any line ending conversions, let me check my local files. What's the current line ending?

strega-nil · 2020-11-25T19:37:21Z

This LGTM, but I want a CTI to look this over; cc @JackBoosY could you look at this this week?

longnguyen2004 · 2020-11-26T03:34:07Z

Regression on mp3lame:x64-windows-static, I'll have a look.
Builds fine on my computer, seems like SourceForge was broken before.

JackBoosY · 2020-11-26T10:00:36Z

Currently working on #14716, will check these regressions tommorrow.

JackBoosY · 2020-11-27T05:57:41Z

ocilib:x64-windows-static:

     2>chromium_base.lib(stack_trace_win.obj) : error LNK2001: unresolved external symbol __imp_SymCleanup [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(stack_trace_win.obj) : error LNK2001: unresolved external symbol __imp_SymSetOptions [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(stack_trace_win.obj) : error LNK2001: unresolved external symbol __imp_SymInitialize [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(stack_trace_win.obj) : error LNK2001: unresolved external symbol __imp_SymGetSearchPathW [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(stack_trace_win.obj) : error LNK2001: unresolved external symbol __imp_SymSetSearchPathW [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(stack_trace_win.obj) : error LNK2001: unresolved external symbol __imp_SymGetModuleBase64 [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(stack_trace_win.obj) : error LNK2001: unresolved external symbol __imp_SymFunctionTableAccess64 [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(stack_trace_win.obj) : error LNK2001: unresolved external symbol __imp_StackWalk64 [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(stack_trace_win.obj) : error LNK2001: unresolved external symbol __imp_SymFromAddr [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(stack_trace_win.obj) : error LNK2001: unresolved external symbol __imp_SymGetLineFromAddr64 [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(stack_trace_win.obj) : error LNK2001: unresolved external symbol SymGetModuleBase64 [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(stack_trace_win.obj) : error LNK2001: unresolved external symbol SymFunctionTableAccess64 [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(win_util.obj) : error LNK2001: unresolved external symbol __imp_SetupDiGetClassDevsW [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(win_util.obj) : error LNK2001: unresolved external symbol __imp_SetupDiEnumDeviceInfo [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(win_util.obj) : error LNK2001: unresolved external symbol __imp_CM_Get_Device_IDW [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(win_util.obj) : error LNK2001: unresolved external symbol __imp_InitPropVariantFromCLSID [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(win_util.obj) : error LNK2001: unresolved external symbol PowerDeterminePlatformRoleEx [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(win_util.obj) : error LNK2001: unresolved external symbol __imp_IsOS [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(pe_image.obj) : error LNK2001: unresolved external symbol __HrLoadAllImportsForDll [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(wmi.obj) : error LNK2001: unresolved external symbol CLSID_WbemLocator [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(file_version_info_win.obj) : error LNK2001: unresolved external symbol VerQueryValueW [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(file_version_info_win.obj) : error LNK2001: unresolved external symbol GetFileVersionInfoSizeW [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(file_version_info_win.obj) : error LNK2001: unresolved external symbol GetFileVersionInfoW [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>chromium_base.lib(file_enumerator_win.obj) : error LNK2001: unresolved external symbol __imp_PathMatchSpecW [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]
     2>D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\lib64\\ociliba.dll : fatal error LNK1120: 24 unresolved externals [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]

Command:

         C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\bin\HostX86\x64\link.exe /ERRORREPORT:QUEUE /OUT:"D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\lib64\\ociliba.dll" /INCREMENTAL:NO /NOLOGO /LIBPATH:"D:/installed/x64-windows-static\lib" /LIBPATH:"D:/installed/x64-windows-static\lib\manual-link" kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib "D:/installed/x64-windows-static\lib\*.lib" /NODEFAULTLIB:ocilib.lib /MANIFEST:NO /DEBUG /PDB:".\..\..\lib64\ociliba.pdb" /SUBSYSTEM:WINDOWS /OPT:REF /LTCG /TLBID:1 /DYNAMICBASE:NO /IMPLIB:"D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\lib64\\ociliba.lib" /MACHINE:X64 /DLL .\temp\main.res  .\temp\agent.obj ...

According to the document, ocilib should link to Dbghelp.lib on Windows.

gdal:x64-linx:

jpeg2000dataset.cpp: In member function ‘int JPEG2000Dataset::DecodeImage()’:
jpeg2000dataset.cpp:516:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
             if (poBand->iDepth != jas_image_cmptprec( psImage, iBand ) ||
                                ^
jpeg2000_vsil_io.cpp:154:1: error: invalid conversion from ‘int (*)(jas_stream_obj_t*, char*, unsigned int) {aka int (*)(void*, char*, unsigned int)}’ to ‘int (*)(jas_stream_obj_t*, const char*, unsigned int) {aka int (*)(void*, const char*, unsigned int)}’ [-fpermissive]
 };
 ^

gdal:x64-osx:

jpeg2000dataset.cpp:516:32: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
            if (poBand->iDepth != jas_image_cmptprec( psImage, iBand ) ||
                ~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
jpeg2000_vsil_io.cpp:151:5: error: cannot initialize a member subobject of type 'int (*)(jas_stream_obj_t *, const char *, unsigned int)' (aka 'int (*)(void *, const char *, unsigned int)') with an lvalue of type 'int (jas_stream_obj_t *, char *, unsigned int)' (aka 'int (void *, char *, unsigned int)'): type mismatch at 2nd parameter ('const char *' vs 'char *')
    JPEG2000_VSIL_write,
    ^~~~~~~~~~~~~~~~~~~

I met these regressions before, currently don't know why it happend again.

About mpg132 and mp3lame regressions, they are download issue, will be solved by rerun the pipeline test.

ports/ffmpeg/portfile.cmake

ports/libogg/portfile.cmake

ports/mp3lame/remove_lame_init_old_from_symbol_list.patch

JackBoosY · 2020-11-27T06:06:59Z

/azp run

azure-pipelines · 2020-11-27T06:07:11Z

Azure Pipelines successfully started running 1 pipeline(s).

ports/mp3lame/portfile.cmake

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

JackBoosY · 2020-11-30T06:08:27Z

Fine, the only regression is about gdal, I will take a look after the CI test finished.

JackBoosY · 2020-12-01T02:07:21Z

It seems that the GDAL regression no longer exists, and I hope it never happens again.

strega-nil · 2020-12-01T22:14:06Z

Awesome! Thanks @longnguyen2004 :)

longnguyen2004 added 11 commits November 11, 2020 22:15

[vcpkg_configure_make] Only rename import libs on MSVC

044286f

[x264] Only rename import libs on MSVC

3ee8976

[x265] Add libc++ and libstdc++ as system libs

f36fbf8

[ffmpeg] mingw support

815d6e0

[libvpx] Set AS environment variable

10e0cf3

[vcpkg_common_definition] Fix a mistake in the prefix and suffix vari…

87cdd0d

…ables

[vcpkg_configure_make] Strip leading -l from lib list before joining

4b72e4d

[mp3lame] Use vcpkg_configure_make + mingw support

ff2e5cf

[x265] Escape the pluses

e7d45b0

[ffmpeg] Add compiler flags for mingw

10c7e65

[ffmpeg] Add WINVER define in mf_utils.c

7eaa145

longnguyen2004 force-pushed the mingw-ffmpeg-related branch from c1955f7 to 7eaa145 Compare November 13, 2020 13:51

[ffmpeg] Remove unnecessary patch in 0003-fic-windowsinclude.patch

e8c7ef2

mcmtroffaes reviewed Nov 13, 2020

View reviewed changes

ports/mp3lame/portfile.cmake Outdated Show resolved Hide resolved

longnguyen2004 and others added 2 commits November 13, 2020 23:04

[mp3lame] Add missing dollar sign

e7995d9

Co-authored-by: Matthias C. M. Troffaes <matthias.troffaes@gmail.com>

Merge branch 'mingw-ffmpeg-related' of https://github.com/longnguyen2…

619d08a

…004/vcpkg into mingw-ffmpeg-related

mcmtroffaes reviewed Nov 13, 2020

View reviewed changes

ports/libvpx/portfile.cmake Show resolved Hide resolved

longnguyen2004 added 2 commits November 14, 2020 08:36

[x265] Remove static lib when building shared with mingw

47fb16c

[libogg] Change library name to libogg on mingw

38b0101

longnguyen2004 marked this pull request as ready for review November 14, 2020 03:28

NancyLi1013 self-assigned this Nov 16, 2020

NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 16, 2020

NancyLi1013 reviewed Nov 16, 2020

View reviewed changes

NancyLi1013 added the requires:author-response label Nov 16, 2020

[libogg] Bump port version

6252905

Merge branch 'master' into mingw-ffmpeg-related

cd9ed37

JackBoosY added the requires:author-response label Nov 24, 2020

[vcpkg_configure_make] Try to fix huge diff

a74fd38

strega-nil removed requires:author-response labels Nov 25, 2020

JackBoosY suggested changes Nov 27, 2020

View reviewed changes

ports/ffmpeg/portfile.cmake Show resolved Hide resolved

ports/libogg/portfile.cmake Show resolved Hide resolved

ports/mp3lame/remove_lame_init_old_from_symbol_list.patch Show resolved Hide resolved

longnguyen2004 mentioned this pull request Nov 28, 2020

[SDL2] SYSTEM_LIBRARIES missing #14779

Closed

JackBoosY suggested changes Nov 30, 2020

View reviewed changes

ports/mp3lame/portfile.cmake Outdated Show resolved Hide resolved

[mp3lame] Add comment on deprecated function lame_init_old

4c647c8

Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>

JackBoosY approved these changes Dec 1, 2020

View reviewed changes

JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 1, 2020

strega-nil merged commit 02f6b89 into microsoft:master Dec 1, 2020

longnguyen2004 deleted the mingw-ffmpeg-related branch December 4, 2020 13:55

longnguyen2004 restored the mingw-ffmpeg-related branch December 4, 2020 13:55

longnguyen2004 deleted the mingw-ffmpeg-related branch December 4, 2020 13:56

longnguyen2004 restored the mingw-ffmpeg-related branch December 4, 2020 13:57

Conversation

longnguyen2004 commented Nov 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

longnguyen2004 commented Nov 14, 2020

Uh oh!

NancyLi1013 left a comment

Choose a reason for hiding this comment

Uh oh!

longnguyen2004 commented Nov 16, 2020

Uh oh!

NancyLi1013 commented Nov 17, 2020

Uh oh!

azure-pipelines bot commented Nov 17, 2020

Uh oh!

JackBoosY commented Nov 24, 2020

Uh oh!

longnguyen2004 commented Nov 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackBoosY commented Nov 24, 2020

Uh oh!

Neumann-A commented Nov 24, 2020

Uh oh!

longnguyen2004 commented Nov 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

strega-nil commented Nov 25, 2020

Uh oh!

longnguyen2004 commented Nov 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackBoosY commented Nov 26, 2020

Uh oh!

JackBoosY commented Nov 27, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JackBoosY commented Nov 27, 2020

Uh oh!

azure-pipelines bot commented Nov 27, 2020

Uh oh!

Uh oh!

JackBoosY commented Nov 30, 2020

Uh oh!

JackBoosY commented Dec 1, 2020

Uh oh!

strega-nil commented Dec 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

longnguyen2004 commented Nov 13, 2020 •

edited

Loading

longnguyen2004 commented Nov 24, 2020 •

edited

Loading

longnguyen2004 commented Nov 24, 2020 •

edited

Loading

longnguyen2004 commented Nov 26, 2020 •

edited

Loading