[xeus] remove openssl static build patch as it is no longer needed#14387
Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom Nov 5, 2020
Merged
[xeus] remove openssl static build patch as it is no longer needed#14387BillyONeal merged 2 commits intomicrosoft:masterfrom
BillyONeal merged 2 commits intomicrosoft:masterfrom
Conversation
LilyWangL
added
the
category:port-bug
LilyWangL
approved these changes
Nov 5, 2020
LilyWangL
added
the
info:needs-maintainer-attention
Member
|
Thanks for your help! |
Contributor
Author
|
You're welcome, and thanks for the quick review and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix? Since [OpenSSL] refactor openssl ports. #14308 has been merged, the vcpkg wrapper for FindOpenSSL now adds crypt32 automatically to the interface link libraries, so the static build patch is no longer required to build xeus.
Which triplets are supported/not supported? Have you updated the CI baseline? No changes.
Does your PR follow the maintainer guide? Yes, to the best of my knowledge.