[vcpkg, azure-macro-utils-c] Fix SHA and add FILE_DISAMBIGUATOR for vcpkg_from_github#14343
Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom Nov 6, 2020
Merged
Conversation
…rent SHA; The current tarballs have a "pax_global_header" with content: 52 comment=7523af934fc4d9423111e358f49b19314ec9c3e3 inside; I suspect somehow github decided to tack that on. I'm not worried about the sources inside being meaningfully different since we're still fetching by git SHA.
BillyONeal
added
category:port-bug
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…the changed SHA512 ref, and add quotes to things.
BillyONeal
changed the title
Member
Author
|
I managed to get my hands on an old copy of the tar.gz from our mac machines and Beyond Compare shows interesting output; it looks like the previous tarball had bugs that have now been fixed even though the extracted content is the same. |
strega-nil
approved these changes
Nov 5, 2020
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow github is serving tarballs with a different SHA; it looks like github upgraded their git backend or something and the results are now slightly different. I was able to get one of the old tarballs from the MacOS build fleet and checked that the contents are the same.
Fixes #14357