[grpc,opencv] Fix cross compile issue.#14318
Closed
x-projs wants to merge 1 commit intomicrosoft:masterfrom
Closed
[grpc,opencv] Fix cross compile issue.#14318x-projs wants to merge 1 commit intomicrosoft:masterfrom
x-projs wants to merge 1 commit intomicrosoft:masterfrom
Conversation
1ff221c to
27319d2
Compare
Grpc requires protoc and grpc_cpp_plugin to compile. Under cross compile case (e.g. host is x64-linux, target is aarch64-linux), we need protoc and grpc_cpp_plugin come from host triplet instead of target triplet.
27319d2 to
44cc1b7
Compare
Contributor
|
Needs cross-talk with #14165 |
Member
|
Closing this PR as it has been obsoleted by "host triplet" support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Grpc/opencv requires protoc and grpc_cpp_plugin to compile.
Under cross compile case (e.g. host is x64-linux, target is aarch64-linux),
we need protoc and grpc_cpp_plugin come from host triplet instead of target
triplet.
What does your PR fix? Fixes #
Under x64-linux,
./vcpkg install grpc:arm-linux/grpc:arm64-linux/opencv:arm-linux/opencv:arm64-linuxwill fail.Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?
yes