Skip to content

[grpc,opencv] Fix cross compile issue.#14318

Closed
x-projs wants to merge 1 commit intomicrosoft:masterfrom
x-projs:xyb/grpc-cross-compile
Closed

[grpc,opencv] Fix cross compile issue.#14318
x-projs wants to merge 1 commit intomicrosoft:masterfrom
x-projs:xyb/grpc-cross-compile

Conversation

@x-projs
Copy link
Contributor

@x-projs x-projs commented Oct 31, 2020

Describe the pull request
Grpc/opencv requires protoc and grpc_cpp_plugin to compile.
Under cross compile case (e.g. host is x64-linux, target is aarch64-linux),
we need protoc and grpc_cpp_plugin come from host triplet instead of target
triplet.

  • What does your PR fix? Fixes #
    Under x64-linux, ./vcpkg install grpc:arm-linux/grpc:arm64-linux/opencv:arm-linux/opencv:arm64-linux will fail.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    • arm64-linux
    • arm-linux
  • Does your PR follow the maintainer guide?
    yes

@x-projs x-projs force-pushed the xyb/grpc-cross-compile branch from 1ff221c to 27319d2 Compare October 31, 2020 02:19
@PhoebeHui PhoebeHui added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 2, 2020
@PhoebeHui PhoebeHui requested a review from BillyONeal November 2, 2020 08:38
Grpc requires protoc and grpc_cpp_plugin to compile.
Under cross compile case (e.g. host is x64-linux, target is aarch64-linux),
we need protoc and grpc_cpp_plugin come from host triplet instead of target
triplet.
@x-projs x-projs force-pushed the xyb/grpc-cross-compile branch from 27319d2 to 44cc1b7 Compare November 5, 2020 15:41
@x-projs x-projs changed the title [grpc] Fix grpc cross compile issue. [grpc,opencv] Fix grpc cross compile issue. Nov 5, 2020
@x-projs x-projs changed the title [grpc,opencv] Fix grpc cross compile issue. [grpc,opencv] Fix cross compile issue. Nov 5, 2020
@strega-nil
Copy link
Contributor

Needs cross-talk with #14165

@strega-nil strega-nil added the depends:different-pr This PR or Issue depends on a PR which has been filed label Nov 12, 2020
@BillyONeal
Copy link
Member

Closing this PR as it has been obsoleted by "host triplet" support.

@BillyONeal BillyONeal closed this Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist depends:different-pr This PR or Issue depends on a PR which has been filed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants