[vcpkg] Implement constraints and overrides in manifests#14183
Merged
ras0219-msft merged 6 commits intomicrosoft:masterfrom Nov 13, 2020
Merged
[vcpkg] Implement constraints and overrides in manifests#14183ras0219-msft merged 6 commits intomicrosoft:masterfrom
ras0219-msft merged 6 commits intomicrosoft:masterfrom
Conversation
JackBoosY
added
category:vcpkg-feature
vicroms
reviewed
Oct 26, 2020
vicroms
approved these changes
Nov 9, 2020
Member
|
@ras0219 is there any work left here? |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…4183) * [vcpkg] Implement constraints in manifests * [vcpkg] Add SourceControlFile::check_against_feature_flags to prevent accidentally ignoring versioning fields * [vcpkg] Switch check_against_feature_flags to accept fs::path * [vcpkg] Implement overrides parsing in manifests * [vcpkg] Address CR comments Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements parsing of constraints and overrides for manifest files as specified in #11758.
It includes guard logic to prevent accidental usage of these new features in manifest files while the experimental
versioningfeature flag is not specified; this ensures users will not be broken as we continue to develop.See especially the tests in
toolsrc/src/vcpkg-test/manifests.cppfor exactly compiling examples.