-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[vcpkg] Implement VersionedPortfileProvider and BaselineProvider #14123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vicroms
merged 52 commits into
microsoft:master
from
vicroms:versioning/versioned-portfile-provider
Nov 27, 2020
Merged
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
e9855e6
WIP: Get versions from database files
vicroms da07a3b
Fix formatting
vicroms f3b82ec
Provider inherits ResourceBase
vicroms 75d5239
Correct versions JSON file location
vicroms e9f7bbd
Fix formatting
vicroms f542bd1
Fix formatting
vicroms a3c7e34
Merge branch 'master' of https://github.com/microsoft/vcpkg into HEAD
ras0219-msft 45a961a
Merge upstream/master into versioning/versioned-portfile-provider
vicroms 3e89145
Fix include in versions.h
vicroms 7a5f7f8
Fetch port versions using git tree object
vicroms ea6639e
Undo changes to x-history
vicroms f52125b
Remove unnecesary moves
vicroms cb84ff5
Merge branch 'master' of https://github.com/microsoft/vcpkg into vers…
vicroms ba655a2
Extract Git manipulation code
vicroms 82b523a
Merge branch 'versioning/versioned-portfile-provider' of https://gith…
vicroms 312209e
Merge branch 'master' of https://github.com/microsoft/vcpkg into vers…
vicroms 964b959
[WIP] Review comments
vicroms 0093995
[WIP] Review comments pt. 2
vicroms 3c8b8d7
Merge branch 'master' of https://github.com/microsoft/vcpkg into vers…
vicroms d73fdd0
[WIP] Review comments / fix formatting
vicroms 91b425a
Merge branch 'master' of github.com:microsoft/vcpkg into versioning/v…
vicroms 377c0f9
Generate baseline.json
vicroms 2c4b35d
Extract deserializers from registries source file
vicroms 0699cf3
BaselineProvider initial implementation
vicroms 5040d82
Modify gitignore
vicroms ff8a732
Update .gitignore again
vicroms af5f87f
Use JSON deserializer for versions db
vicroms ab6127a
Lazy load baseline file
vicroms fc817d5
Fetch baseline.json from baseline commit
vicroms 9d64b34
More git abstractions
vicroms ff617b1
Clean up code
vicroms 01bfaac
Merge branch 'master' of github.com:microsoft/vcpkg into versioning/v…
vicroms 6818069
Path helpers
vicroms 34474ad
Formatting
vicroms 1054129
Move data into impl object
vicroms 2c90cb4
Use implementation object for VersionedPortfileProvider
vicroms 0bcaa15
Reuse cloned instance for checkouts
vicroms cfb807d
Code cleanup and formatting
vicroms 03b3e52
Fix returning dangling reference
vicroms a292cf4
Merge branch 'master' of github.com:microsoft/vcpkg into versioning/v…
vicroms 360dd3a
Prepare to remove files in port_versions/
vicroms 3f0893f
Remove files in port_versions/
vicroms c8f570d
Update .gitignore
vicroms 50535d2
Some PR review comments
vicroms b946647
Use StringView
vicroms 37233ba
More StringView conversions
vicroms 222cdd5
More refactoring
vicroms 26bd212
Make some implementation members private
vicroms c12a53c
Functions for parsing baseline and version files
vicroms 6e3824a
Merge branch 'master' of github.com:microsoft/vcpkg into versioning/v…
vicroms 3a0e613
Hide deserializers implementation
vicroms 143ea21
Check for `versions` feature flag in registries.
vicroms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| #pragma once | ||
|
|
||
| #include <vcpkg/base/fwd/stringview.h> | ||
|
|
||
| #include <vcpkg/base/jsonreader.h> | ||
| #include <vcpkg/base/stringliteral.h> | ||
|
|
||
| #include <vcpkg/versions.h> | ||
| #include <vcpkg/versiont.h> | ||
|
|
||
| namespace vcpkg | ||
| { | ||
| struct VersionDbEntry | ||
| { | ||
| VersionT version; | ||
| Versions::Scheme scheme; | ||
| std::string git_tree; | ||
|
|
||
| VersionDbEntry(const std::string& version_string, | ||
| int port_version, | ||
| Versions::Scheme scheme, | ||
| const std::string& git_tree) | ||
| : version(VersionT(version_string, port_version)), scheme(scheme), git_tree(git_tree) | ||
| { | ||
| } | ||
| }; | ||
|
|
||
| Json::IDeserializer<VersionT>& get_versiont_deserializer_instance(); | ||
|
|
||
| ExpectedS<std::map<std::string, VersionT, std::less<>>> parse_baseline_file(Files::Filesystem& fs, | ||
| StringView baseline_name, | ||
| const fs::path& baseline_file_path); | ||
|
|
||
| ExpectedS<std::vector<VersionDbEntry>> parse_versions_file(Files::Filesystem& fs, | ||
| StringView port_name, | ||
| const fs::path& versions_file_path); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.