Skip to content

[openimageio] Update to version 2.2.7.0#13966

Closed
brukted wants to merge 7 commits intomicrosoft:masterfrom
brukted:update-openimageio
Closed

[openimageio] Update to version 2.2.7.0#13966
brukted wants to merge 7 commits intomicrosoft:masterfrom
brukted:update-openimageio

Conversation

@brukted
Copy link
Contributor

@brukted brukted commented Oct 10, 2020 •
edited by LilyWangL
Loading

Describe the pull request

Hoikas
Hoikas reviewed Oct 12, 2020
View reviewed changes
ports/openimageio/CONTROL
Homepage: https://github.com/OpenImageIO/oiio
Description: A library for reading and writing images, and a bunch of related classes, utilities, and application
Build-Depends: libjpeg-turbo, tiff, libpng, libheif, openexr, boost-thread, boost-smart-ptr, boost-foreach, boost-regex, boost-type-traits, boost-static-assert, boost-unordered, boost-config, boost-algorithm, boost-filesystem, boost-system, boost-thread, boost-asio, boost-random, robin-map, boost-stacktrace, fmt
Build-Depends: libjpeg-turbo, tiff, libpng, libheif, openexr, boost-thread, boost-smart-ptr, boost-foreach, boost-regex, boost-type-traits, boost-static-assert, boost-unordered, boost-config, boost-algorithm, boost-filesystem, boost-system, boost-thread, boost-asio, boost-random, robin-map, boost-stacktrace, fmt, python2
Copy link
Contributor

@Hoikas Hoikas Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we now depend on python2? The feature pybind11 implies that it builds the python bindings. Further, it seems inappropriate to build bindings for a sunsetted version of the python interpreter.

@brukted @Hoikas
Update ports/openimageio/CONTROL
ed1f30c 
Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>
@LilyWangL LilyWangL changed the title Update OpenImageIO [openimageio] Update to version 2.2.7 Oct 12, 2020
@LilyWangL LilyWangL changed the title [openimageio] Update to version 2.2.7 [openimageio] Update to version 2.2.7.0 Oct 12, 2020
@LilyWangL LilyWangL added category:port-update The issue is with a library, which is requesting update new revision requires:all-feature-testing labels Oct 12, 2020
@brukted brukted marked this pull request as draft October 12, 2020 09:53
@JonLiu1993 JonLiu1993 mentioned this pull request Oct 13, 2020
Closed
@LilyWangL
Copy link
Contributor

LilyWangL commented Oct 15, 2020

@brukted Thanks for your PR. I test all features and openimageio[pybind11] build failed with the following error:

-- Found PythonInterp: F:/Lily/pr13966/vcpkg/downloads/tools/python/python-3.8.3-x86/python.exe (found version "3.8.3") 
CMake Error at F:/Lily/pr13966/vcpkg/installed/x86-windows/share/pybind11/FindPythonLibsNew.cmake:161 (message):
  Python libraries not found
Call Stack (most recent call first):
  F:/Lily/pr13966/vcpkg/scripts/buildsystems/vcpkg.cmake:496 (_find_package)
  F:/Lily/pr13966/vcpkg/installed/x86-windows/share/pybind11/pybind11Tools.cmake:16 (find_package)
  F:/Lily/pr13966/vcpkg/installed/x86-windows/share/pybind11/pybind11Config.cmake:100 (include)
  F:/Lily/pr13966/vcpkg/scripts/buildsystems/vcpkg.cmake:496 (_find_package)
  src/cmake/checked_find_package.cmake:81 (find_package)
  src/python/CMakeLists.txt:7 (checked_find_package)


-- Configuring incomplete, errors occurred!

And could you resolve conflicts?

@brukted
Copy link
Contributor Author

brukted commented Oct 15, 2020

@LilyWangL I will try to resolve the issue. It seems the problem is with pybind11/FindPythonLibsNew.cmake it self in fact there are a lot of issues about it on the pybind11 repo.

@Hoikas
Copy link
Contributor

Hoikas commented Oct 15, 2020

While working on #13556, I found that the pybind11 python artifact specification is incorrect. They are referring to python 3.6 instead of python 3.8.

@brukted
Copy link
Contributor Author

brukted commented Oct 15, 2020

Waiting for #13556 to be merged.

@Hoikas
Copy link
Contributor

Hoikas commented Oct 15, 2020

@brukted That PR is being delayed for a more in depth review. It might be better to fix pybind11 here or in another PR. I don't mind resolving conflicts in my PR 😄

@LilyWangL LilyWangL added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Oct 16, 2020
@NancyLi1013 NancyLi1013 self-assigned this Nov 12, 2020
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Nov 19, 2020

@brukted

Could you please resolve conflicts?

@Hoikas
Copy link
Contributor

Hoikas commented Nov 20, 2020

@brukted The pybind issue should have been fixed in #14510 😄

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Dec 25, 2020

ping @brukted for response.
Is work still being done for this PR?

@brukted
Copy link
Contributor Author

brukted commented Dec 26, 2020

@NancyLi1013 yes.

@brukted brukted closed this Jan 6, 2021
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Jan 7, 2021

Why do you close this PR?

@brukted
Copy link
Contributor Author

brukted commented Jan 30, 2021

It is because I have to cover a whole semester in a month.

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Feb 1, 2021

Thanks for your reply @brukted.

You can reopen this PR if you'd like to continue working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Hoikas Hoikas Hoikas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

@LilyWangL LilyWangL

Labels

category:port-update The issue is with a library, which is requesting update new revision depends:different-pr This PR or Issue depends on a PR which has been filed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[openimageio] update to 2.2.6.1 [openimageio:x64-linux] build failure

5 participants

@brukted @LilyWangL @Hoikas @NancyLi1013 @JonLiu1993