Skip to content

[qca]support linux-osx-static build#13964

Merged
dan-shaw merged 20 commits intomicrosoft:masterfrom
longhuan2018:fix-qca-linux-osx-bug
Oct 12, 2020
Merged

[qca]support linux-osx-static build#13964
dan-shaw merged 20 commits intomicrosoft:masterfrom
longhuan2018:fix-qca-linux-osx-bug

Conversation

@longhuan2018
Copy link
Contributor

Upgrade qca library to 2.3.1
Make qca compile under linux and osx
Support qca static library compilation

@NancyLi1013 NancyLi1013 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision labels Oct 12, 2020
@NancyLi1013
Copy link
Contributor

The failure on osx:

-- Performing post-build validation
The folder /include is empty or not present. This indicates the library was not correctly installed.
Found 1 error(s). Please correct the portfile:
    /Volumes/data/work/1/s/ports/qca/portfile.cmake
-- Performing post-build validation done

Copy link
Contributor

@NancyLi1013 NancyLi1013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also update this

file(COPY ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/qca)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/qca/COPYING ${CURRENT_PACKAGES_DIR}/share/qca/copyright)

as

file(INSTALL ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)?

@NancyLi1013
Copy link
Contributor

Related PR #13961

longhuan2018 and others added 6 commits October 12, 2020 15:55
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@longhuan2018
Copy link
Contributor Author

Now this PR has been compiled. My PR already contains the content of PR #13961. @NancyLi1013

@NancyLi1013
Copy link
Contributor

@longhuan2018
Thanks for your efforts.
Of course, PR #13961 is just a update, which has been included in your PR.

LGTM now.

@NancyLi1013 NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Oct 12, 2020
@dan-shaw dan-shaw merged commit 9bf57ae into microsoft:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants