Skip to content

[libvorbis] Fix Windows build when VCPKG_BUILD_TYPE is set#13796

Closed
past-due wants to merge 1 commit intomicrosoft:masterfrom
past-due:2020_fix_libvorbis_build_type_1
Closed

[libvorbis] Fix Windows build when VCPKG_BUILD_TYPE is set#13796
past-due wants to merge 1 commit intomicrosoft:masterfrom
past-due:2020_fix_libvorbis_build_type_1

Conversation

@past-due
Copy link
Contributor

This should fix libvorbis port builds on Windows when VCPKG_BUILD_TYPE is set

  • What does your PR fix?

Fixes #13795

  • Which triplets are supported/not supported? Have you updated the CI baseline?

No changes to support.

@PhoebeHui PhoebeHui self-assigned this Sep 29, 2020
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Sep 29, 2020
@dan-shaw
Copy link
Contributor

dan-shaw commented Oct 2, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@past-due
Copy link
Contributor Author

past-due commented Oct 5, 2020

@JackBoosY @dan-shaw The errors I'm seeing in CI do not appear to be released to this PR? (Same as #13801?)

@JackBoosY
Copy link
Contributor

Please merge to master branch.

@dan-shaw
Copy link
Contributor

dan-shaw commented Oct 6, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@past-due
Copy link
Contributor Author

past-due commented Oct 7, 2020

It looks like #13795 was fixed in a different way by 72d9852. This PR should no longer be needed.

@past-due past-due closed this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[libvorbis] Windows build fails when VCPKG_BUILD_TYPE is set

5 participants