[atk][exiv2][gdk-pixbuf][gettext][glib][libcroco][tesseract] Replace uses of unofficial-gettext with FindIntl#13762
Closed
ras0219 wants to merge 9 commits intomicrosoft:masterfrom
Closed
[atk][exiv2][gdk-pixbuf][gettext][glib][libcroco][tesseract] Replace uses of unofficial-gettext with FindIntl#13762ras0219 wants to merge 9 commits intomicrosoft:masterfrom
ras0219 wants to merge 9 commits intomicrosoft:masterfrom
Conversation
…uses of unofficial-gettext with FindIntl
JackBoosY
added
category:port-bug
Contributor
|
I think this might've been fixed already by @Neumann-A in #11776, no? |
Contributor
|
After compared with PR #11776, the changes for gettext still needed, I will help to undo changes for other ports and resolve the conflicts. |
PhoebeHui
force-pushed
the
dev/roschuma/gettext
branch
2 times, most recently
from
008aafa to
1018990
Compare
PhoebeHui
requested changes
Dec 11, 2020
Comment on lines
+62
to
+63
| # These targets are provided for backwards compatibility with previous vcpkg versions | ||
| vcpkg_fixup_cmake_targets(CONFIG_PATH share/unofficial-gettext TARGET_PATH share/unofficial-gettext) |
Contributor
There was a problem hiding this comment.
The CI failed with following errors:
Make Error at scripts/cmake/vcpkg_fixup_cmake_targets.cmake:126 (message):
'D:/packages/gettext_x64-windows-static/debug/share/unofficial-gettext'
does not exist.
Call Stack (most recent call first):
ports/gettext/portfile.cmake:63 (vcpkg_fixup_cmake_targets)
scripts/ports.cmake:136 (include)
Contributor
There was a problem hiding this comment.
it does not exists anymore since gettext was changed to native build which is make based
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See title. See also #13027.
We prefer supporting built-in cmake modules whenever possible instead of providing our own replacements.