Skip to content

[vcpkg_common_definitions] Add macro VCPKG_HOST_IS_<target>#13730

Merged
dan-shaw merged 4 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/vcpkg_host_is_target
Oct 17, 2020
Merged

[vcpkg_common_definitions] Add macro VCPKG_HOST_IS_<target>#13730
dan-shaw merged 4 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/vcpkg_host_is_target

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Sep 25, 2020

Provide host architecture macros to the cross-platform compilation environment instead of CMAKE_HOST_WIN32 etc.

  • VCPKG_HOST_IS_WINDOWS
  • VCPKG_HOST_IS_OSX
  • VCPKG_HOST_IS_LINUX
  • VCPKG_HOST_IS_DARWIN

Related: #10913.

@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal labels Sep 25, 2020
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JackBoosY
Copy link
Contributor Author

blocked by #13765.

@ras0219-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 9, 2020
@dan-shaw dan-shaw added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Oct 14, 2020
@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Oct 16, 2020
@dan-shaw dan-shaw merged commit b69056b into microsoft:master Oct 17, 2020
@JackBoosY JackBoosY deleted the dev/jack/vcpkg_host_is_target branch October 19, 2020 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants