[netcdf-c/nvtt] Update to the latest version by NancyLi1013 · Pull Request #13674 · microsoft/vcpkg

NancyLi1013 · 2020-09-23T06:00:29Z

Update to the latest version

Note: No feature needs to test.

ras0219-msft · 2020-09-28T01:17:26Z

ports/nvtt/squish.patch

+@@ -21,3 +21,8 @@ SET(SQUISH_SRCS
+ 	simd_ve.h)

+ ADD_LIBRARY(nvsquish STATIC ${SQUISH_SRCS})


Does this library also need to be installed?

Yes, it seems to be needed by OSG. Please see here #6611 (comment).

NancyLi1013 · 2020-09-28T07:04:48Z

nvtt: x86-windows failed like this:

nvcc fatal   : 32 bit compilation is only supported for Microsoft Visual Studio 2013 and earlier
CMake Error at cuda_compile_1_generated_CompressKernel.cu.obj.Debug.cmake:220 (message):
  Error generating
  D:/buildtrees/nvtt/x86-windows-dbg/src/nvtt/CMakeFiles/cuda_compile_1.dir/cuda/./cuda_compile_1_generated_CompressKernel.cu.obj

So I will add Supports: !x86 to skip the check on CI.

PhoebeHui

LGTM

dan-shaw · 2020-10-06T20:21:29Z

/azp run

azure-pipelines · 2020-10-06T20:21:34Z

No pipelines are associated with this pull request.

NancyLi1013 · 2020-10-12T09:28:03Z

nvtt failed on osx is due to this error:

In file included from /Users/vagrant/Data/buildtrees/nvtt/src/2188752e3f-1c6503c2c5.clean/src/nvtt/icbc.cpp:3:
/Users/vagrant/Data/buildtrees/nvtt/src/2188752e3f-1c6503c2c5.clean/src/nvtt/icbc.h:2797:12: error: always_inline function '_pdep_u32' requires target feature 'bmi2', but would be inlined into function 'interleave' that is compiled without support for 'bmi2'
    return _pdep_u32(a, 0x55555555) | _pdep_u32(b, 0xaaaaaaaa);
           ^
/Users/vagrant/Data/buildtrees/nvtt/src/2188752e3f-1c6503c2c5.clean/src/nvtt/icbc.h:2797:39: error: always_inline function '_pdep_u32' requires target feature 'bmi2', but would be inlined into function 'interleave' that is compiled without support for 'bmi2'
    return _pdep_u32(a, 0x55555555) | _pdep_u32(b, 0xaaaaaaaa);
                                      ^
/Users/vagrant/Data/buildtrees/nvtt/src/2188752e3f-1c6503c2c5.clean/src/nvtt/icbc.h:656:12: error: always_inline function '_mm256_fmadd_ps' requires target feature 'fma', but would be inlined into function 'vmadd' that is compiled without support for 'fma'
    return _mm256_fmadd_ps(a, b, c);
           ^
/Users/vagrant/Data/buildtrees/nvtt/src/2188752e3f-1c6503c2c5.clean/src/nvtt/icbc.h:666:12: error: always_inline function '_mm256_fmsub_ps' requires target feature 'fma', but would be inlined into function 'vmsub' that is compiled without support for 'fma'
    return _mm256_fmsub_ps(a, b, c);
           ^
4 errors generated.

But I cannot reproduce this on my local machine.

…yLi1013/vcpkg into dev/NancyLi/update-netcdf-c

JackBoosY · 2020-10-16T09:49:47Z

@strega-nil Could you please take a look at osx failure?

Thanks.

PhoebeHui · 2020-10-19T07:52:11Z

/azp run

azure-pipelines · 2020-10-19T07:52:23Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2020-10-20T02:37:11Z

/azp run

azure-pipelines · 2020-10-20T02:37:28Z

Azure Pipelines successfully started running 1 pipeline(s).

…NancyLi/update-netcdf-c

NancyLi1013 · 2020-10-21T09:43:49Z

@strega-nil
I try to rebuild this on our local osx machine. But I still cannot reproduce it now.
I also checked the config and build log and I didn't found any exception about this.

The osx machine used the same compiler as that in CI.

-- The C compiler identification is AppleClang 12.0.0.12000032
-- The CXX compiler identification is AppleClang 12.0.0.12000032

I have no idea about this issue now.

Could you please help take a look and give some suggestions?

Thanks.

strega-nil · 2020-10-21T16:31:13Z

@NancyLi1013 weird; I was able to repro it in the VM, though, so there's clearly an issue.

Use the VM that's on vcpkgmm-03; you can get into it by accessing:

vcpkgmm-03$ cd ~/vagrant/vcpkg-eg-mac
vcpkgmm-03$ vagrant ssh

and then you'll find the vcpkg root with this SHA checked out at ~/vcpkg in the VM.
Make sure to remember to set up your environment variables inside the VM:

$ export VCPKG_DEFAULT_BINARY_CACHE=/Users/vagrant/Data/archives
$ export VCPKG_DOWNLOADS=/Users/vagrant/Data/downloads
$ export WORKING_ROOT=/Users/vagrant/Data

NancyLi1013 · 2020-10-22T01:36:11Z

Thanks for your help and suggestions @strega-nil . I will try to reproduce this first according to your above guidelines.

NancyLi1013 · 2020-10-22T02:56:27Z

It seems that we have no permission to access the VM machine vcpkgmm-03. I try to connect to this machine and it failed like this:

Password:
Access denied
Using keyboard-interactive authentication.
Password:

PhoebeHui · 2020-10-22T07:17:49Z

Try to fix the issue on osx by adding compile option '-mbmi2 -mfma' to nvtt on osx.

See more information about the failure: https://stackoverflow.com/questions/59590790/how-to-enable-instrinsic-functions-from-the-preprocessor

NancyLi1013 · 2020-10-22T08:36:08Z

Thanks for your help to fix this issue on osx @PhoebeHui.

Sorry for my mistake to use the wrong command.

BillyONeal · 2020-10-23T07:26:53Z

@NancyLi1013 I think Robert's code review comment is that you are patching in an add_library but aren't patching in an equivalent install to install that library. Can you confirm this is doing the right thing for install? /cc @ras0219 @ras0219-msft

NancyLi1013 · 2020-10-23T10:10:03Z

@BillyONeal
Thanks for your review and pointing this out.

It seems that the targets name installed should be nvsquish instead of squish , which is different between version 2.1.1 and 2.1.2.

I will update it soon.

ports/nvtt/squish.patch

BillyONeal · 2020-10-24T00:31:04Z

Thanks for your contribution!

This was regressed by microsoft#13674 REGRESSION: nvtt:x64-linux. If expected, add nvtt:x64-linux=fail to .\scripts\ci.baseline.txt. REGRESSION: nvtt:x64-osx. If expected, add nvtt:x64-osx=fail to .\scripts\ci.baseline.txt. REGRESSION: nvtt:x64-windows-static. If expected, add nvtt:x64-windows-static=fail to .\scripts\ci.baseline.txt. REGRESSION: nvtt:x64-windows. If expected, add nvtt:x64-windows=fail to .\scripts\ci.baseline.txt. Installing package nvtt[core]:x64-linux... The following files are already installed in /mnt/vcpkg-ci/installed/x64-linux and are in conflict with nvtt:x64-linux Installed by libsquish:x64-linux debug/lib/libsquishd.a include/squish.h lib/libsquish.a

* [libp7client, libp7-baical] Combine identical ports and update to libp7client 5.6. In a recent CI build, we started getting output like: Installing package libp7-baical[core]:x86-windows... The following files are already installed in C:/Dev/vcpkg/installed/x86-windows and are in conflict with libp7-baical:x86-windows Installed by libp7client:x86-windows bin/P7x32.dll bin/P7x32.pdb debug/bin/P7x32d.dll debug/bin/P7x32d.pdb include/P7/GTypes.h include/P7/P7_Client.h include/P7/P7_Cproxy.h include/P7/P7_Extensions.h include/P7/P7_Telemetry.h include/P7/P7_Trace.h It turns out that these ports are identical, they are just different versions of the same library. The libp7-baical version supported more platforms and was simpler, so took that one and updated it to a current version. * [ignition-modularscripts, ignition-msgs1] Attempt to fix intermittent build failures by disabling parallel configure. * Fix several "passing: remove from fail list." * [akali] Disable parallel configure. REGRESSION: akali:x64-windows. If expected, add akali:x64-windows=fail to .\scripts\ci.baseline.txt. Attempts to fix: CMake Error: Could not open file for write in copy operation C:/Dev/vcpkg/buildtrees/akali/src/fc94eb83a9-01654d3f7c.clean/include/akali_config.h.tmp CMake Error: : System Error: Permission denied CMake Error at CMakeLists.txt:20 (configure_file): configure_file Problem configuring file * [nvtt] Devendor libsquish This was regressed by #13674 REGRESSION: nvtt:x64-linux. If expected, add nvtt:x64-linux=fail to .\scripts\ci.baseline.txt. REGRESSION: nvtt:x64-osx. If expected, add nvtt:x64-osx=fail to .\scripts\ci.baseline.txt. REGRESSION: nvtt:x64-windows-static. If expected, add nvtt:x64-windows-static=fail to .\scripts\ci.baseline.txt. REGRESSION: nvtt:x64-windows. If expected, add nvtt:x64-windows=fail to .\scripts\ci.baseline.txt. Installing package nvtt[core]:x64-linux... The following files are already installed in /mnt/vcpkg-ci/installed/x64-linux and are in conflict with nvtt:x64-linux Installed by libsquish:x64-linux debug/lib/libsquishd.a include/squish.h lib/libsquish.a * [knet] Disable parallel configure. REGRESSION: knet:x64-windows. If expected, add knet:x64-windows=fail to .\scripts\ci.baseline.txt. CMake Error at src/CMakeLists.txt:1 (configure_file): configure_file Problem configuring file * [libnice] Diable parallel configure. REGRESSION: libnice:x64-windows. If expected, add libnice:x64-windows=fail to .\scripts\ci.baseline.txt. CMake Error at CMakeLists.txt:13 (configure_file): configure_file Problem configuring file

[netcdf-c/nvtt] Update to the latest version

b1fa60c

NancyLi1013 added info:internal category:port-update The issue is with a library, which is requesting update new revision labels Sep 23, 2020

NancyLi1013 assigned PhoebeHui Sep 23, 2020

NancyLi1013 added 2 commits September 23, 2020 02:37

[nvtt] Fix build error

0d7c57c

[nvtt] Update patch

9eef55d

ras0219-msft reviewed Sep 28, 2020

View reviewed changes

[nvtt] Add unsupported x86

ee80fc4

PhoebeHui approved these changes Sep 29, 2020

View reviewed changes

PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 29, 2020

Merge remote-tracking branch 'origin/master' into HEAD

a70f93f

PhoebeHui removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 12, 2020

NancyLi1013 added 2 commits October 13, 2020 02:27

[nvtt] Try to fix the problem on osx

dae86a0

Merge branch 'dev/NancyLi/update-netcdf-c' of https://github.com/Nanc…

2b356c0

…yLi1013/vcpkg into dev/NancyLi/update-netcdf-c

NancyLi1013 added 2 commits October 19, 2020 19:48

Merge branch 'master' of https://github.com/Microsoft/vcpkg into dev/…

63adc73

…NancyLi/update-netcdf-c

[nvtt] Remove the compile option patch to retrigger CI

313cd7c

Try to address the issue on osx

45c409b

PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 22, 2020

strega-nil approved these changes Oct 22, 2020

View reviewed changes

BillyONeal added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Oct 23, 2020

NancyLi1013 commented Oct 23, 2020

View reviewed changes

ports/nvtt/squish.patch Outdated Show resolved Hide resolved

Update ports/nvtt/squish.patch

9e73b92

BillyONeal merged commit a97e32f into microsoft:master Oct 24, 2020

BillyONeal mentioned this pull request Oct 25, 2020

[Many Ports] Baseline Fixes for 2020-10-24 CI Build #14208

Merged

Conversation

NancyLi1013 commented Sep 23, 2020

Uh oh!

ras0219-msft Sep 28, 2020

Choose a reason for hiding this comment

Uh oh!

NancyLi1013 Sep 28, 2020

Choose a reason for hiding this comment

Uh oh!

NancyLi1013 commented Sep 28, 2020

Uh oh!

PhoebeHui left a comment

Choose a reason for hiding this comment

Uh oh!

dan-shaw commented Oct 6, 2020

Uh oh!

azure-pipelines bot commented Oct 6, 2020

Uh oh!

NancyLi1013 commented Oct 12, 2020

Uh oh!

JackBoosY commented Oct 16, 2020

Uh oh!

PhoebeHui commented Oct 19, 2020

Uh oh!

azure-pipelines bot commented Oct 19, 2020

Uh oh!

NancyLi1013 commented Oct 20, 2020

Uh oh!

azure-pipelines bot commented Oct 20, 2020

Uh oh!

NancyLi1013 commented Oct 21, 2020

Uh oh!

strega-nil commented Oct 21, 2020

Uh oh!

NancyLi1013 commented Oct 22, 2020

Uh oh!

NancyLi1013 commented Oct 22, 2020

Uh oh!

PhoebeHui commented Oct 22, 2020

Uh oh!

NancyLi1013 commented Oct 22, 2020

Uh oh!

BillyONeal commented Oct 23, 2020

Uh oh!

NancyLi1013 commented Oct 23, 2020

Uh oh!

Uh oh!

BillyONeal commented Oct 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants