[v-hacd] Fix cmake patch for include files#13549
Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom Oct 9, 2020
Merged
[v-hacd] Fix cmake patch for include files#13549BillyONeal merged 2 commits intomicrosoft:masterfrom
BillyONeal merged 2 commits intomicrosoft:masterfrom
Conversation
ras0219-msft
requested changes
Sep 16, 2020
Contributor
ras0219-msft
left a comment
ras0219-msft
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please also modify the CONTROL file to introduce a Port-Version: 1 below the current Version: field.
PhoebeHui
added
category:port-bug
Contributor
Author
|
Thanks for the review, I amended the commit with the requested changes. |
PhoebeHui
approved these changes
Sep 17, 2020
Contributor
PhoebeHui
left a comment
PhoebeHui
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR!
PhoebeHui
added
info:needs-maintainer-attention
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt at fixing the v-hacd port. It fixes the target include directory so that the public include file
VHACD.hcan be found in the include path. It also stops installing the private header files in order to reduce clutter.I think the patch+portfile from the port (and also the CMakeLists from the project repository) could benefit from some rework (cleanup, simplification, fix of shared library), unfortunately I am unable to do it at the moment. The changes are the minimum I had to do to make it work on my machine.
Tested with x64-windows and VS2019. What is the CI baseline ?
Let me know if anything is missing or feel free to take over from here.