[ffmpeg] Fix bug #13511: arm64-linux build failure#13512
Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom Sep 14, 2020
Merged
[ffmpeg] Fix bug #13511: arm64-linux build failure#13512ras0219-msft merged 1 commit intomicrosoft:masterfrom
ras0219-msft merged 1 commit intomicrosoft:masterfrom
Conversation
…ild failure. Root cause: In `ffmpeg/portfile.cmake`, `--target-os=win32` is applied to all arm or arm64 targets. This is wrong. Fix: Only apply "--target-os=win32" if VCPKG_TARGET_IS_WINDOWS. Verify: Run `./vcpkg install ffmpeg` on arm64-linux host, make sure the generated libraries are *.a not *.lib.
Contributor
|
I’d add that also implying cross-compile if win+arm64 is another mistake too (it will become a common setup soon) |
JackBoosY
added
the
category:port-bug
JackBoosY
approved these changes
Sep 14, 2020
JackBoosY
added
the
info:needs-maintainer-attention
JackBoosY
changed the title
Contributor
|
LGTM, thanks for the improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix? Fixes #
Fix bug [ffmpeg:arm64-linux] build failure #13511: [ffmpeg:arm64-linux] build failure.
Which triplets are supported/not supported? Have you updated the CI baseline?
arm64-linux
Does your PR follow the maintainer guide?
Yes