[hffix] New port hffix library 1.0.0#13433
Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom Sep 11, 2020
gnaggnoyil:master
Merged
[hffix] New port hffix library 1.0.0#13433ras0219-msft merged 1 commit intomicrosoft:masterfrom gnaggnoyil:master
ras0219-msft merged 1 commit intomicrosoft:masterfrom
gnaggnoyil:master
Conversation
NancyLi1013
suggested changes
Sep 10, 2020
ports/hffix/portfile.cmake
Outdated
Comment on lines
3
to
7
Contributor
There was a problem hiding this comment.
Suggested change
| vcpkg_from_github( | |
| OUT_SOURCE_PATH SOURCE_PATH | |
| REPO jamesdbrock/hffix | |
| REF v1.0.0 | |
| SHA512 0043b789e6ffdc32eaf2736a8621dd7fd54e1a16aae33bb1d5f642da1b04d150ed42d8f9ddd046013242164854d9091540452153f09459d05f9bf4a186c7b860 | |
| vcpkg_from_github( | |
| OUT_SOURCE_PATH SOURCE_PATH | |
| REPO jamesdbrock/hffix | |
| REF v1.0.0 | |
| SHA512 0043b789e6ffdc32eaf2736a8621dd7fd54e1a16aae33bb1d5f642da1b04d150ed42d8f9ddd046013242164854d9091540452153f09459d05f9bf4a186c7b860 | |
| HEAD_REF master |
ports/hffix/portfile.cmake
Outdated
Comment on lines
12
to
14
Contributor
There was a problem hiding this comment.
Suggested change
| vcpkg_configure_cmake( | |
| SOURCE_PATH ${SOURCE_PATH} | |
| PREFER_NINJA | |
| vcpkg_configure_cmake( | |
| SOURCE_PATH ${SOURCE_PATH} | |
| PREFER_NINJA |
ports/hffix/CMakeLists.txt
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| add_library(hffix-header INTERFACE) | |
| add_library(hffix INTERFACE) |
In my opinion, it might be better to rename it as hffix.
ports/hffix/CMakeLists.txt
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| target_include_directories(hffix-header INTERFACE | |
| target_include_directories(hffix INTERFACE |
ports/hffix/CMakeLists.txt
Outdated
Contributor
There was a problem hiding this comment.
Suggested change
| TARGETS hffix-header | |
| TARGETS hffix |
NancyLi1013
added
category:new-port
NancyLi1013
approved these changes
Sep 11, 2020
NancyLi1013
added
info:needs-maintainer-attention
Contributor
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix? Fixes [New Port Request] hffix #13432
Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?