[libsigcpp-3] Add new port#13412
Merged
BillyONeal merged 8 commits intomicrosoft:masterfrom Oct 7, 2020
brukted:master
Merged
Conversation
LilyWangL
added
the
category:new-port
LilyWangL
approved these changes
Sep 9, 2020
LilyWangL
added
the
info:needs-maintainer-attention
ras0219-msft
requested changes
Sep 9, 2020
Contributor
ras0219-msft
left a comment
ras0219-msft
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Looks good to me once these comments are addressed.
LilyWangL
removed
the
info:needs-maintainer-attention
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@LilyWangL @ras0219-msft I think this pr is ready to merge. |
LilyWangL
added
info:needs-maintainer-attention
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix? Fixes Add new port [libsigcpp-3] #13409 Fixes [New Port Request] libsigcpp-3 #13379
Does your PR follow the maintainer guide? yes
Submission containing materials of a third party: The libsigc++ Development Team under GPL-3.0 License