[vcpkg] Further JSON error improvements#13399
Merged
ras0219-msft merged 19 commits intomicrosoft:masterfrom Oct 12, 2020
Merged
[vcpkg] Further JSON error improvements#13399ras0219-msft merged 19 commits intomicrosoft:masterfrom
ras0219-msft merged 19 commits intomicrosoft:masterfrom
Conversation
These types are only used by VcpkgPaths during the initial parse.
Contributor
|
Putting myself as a required reviewer. |
36c1bdc to
be965ca
Compare
strega-nil
suggested changes
Sep 9, 2020
strega-nil
reviewed
Sep 10, 2020
strega-nil
reviewed
Sep 10, 2020
Contributor
strega-nil
left a comment
There was a problem hiding this comment.
Just a few things left :)
strega-nil
approved these changes
Oct 6, 2020
… allowed in features objects
…etter match declaration
strega-nil
approved these changes
Oct 9, 2020
5e82e99 to
091b12e
Compare
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* [vcpkg] Split vcpkg/base/json.h into vcpkg/base/jsonreader.h * [vcpkg] Extract definitions of Configuration-Deserializer (& friends) These types are only used by VcpkgPaths during the initial parse. * [vcpkg] Introduce levenshtein-distance suggestions for json errors * [vcpkg] Fix regression in supports handling * [vcpkg] Fix signed/unsigned mismatch * [vcpkg] Address CR comments * [vcpkg] Address CR comments * Fix compiler error from merge conflict. * [vcpkg] Change parameters of Reader::check_for_unexpected_fields to better match declaration * [vcpkg] Improve errors from features set * [vcpkg] Fix includes * [vcpkg] Reuse code * [vcpkg] Check the "name" field always to maximize error information * [docs] Improve english phrasing in manifests.md * [vcpkg] Correct docs link for manifests Co-authored-by: Robert Schumacher <roschuma@microsoft.com> Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
json.h) and parser (jsonreader.h) to reduce unintended dependencies across the codebase. The same refactor is also applied to Configuration/ConfigurationDeserializer.identifiererror message.Potential future work includes applying this levenshtein-distance calculation to search results.
As a drive by, this PR documents that comment fields (
$xyz) are not supported in objects being used as sets with user-defined keys; they are only allowed in "struct-like" objects with a defined keyspace.Example 1
{ "name": "Abseil", ... }Example 2
{ .., "depednecies": ["foo"], ... }Example 3
{ ..., "features": { "$abc" : true } }