Skip to content

[libtorrent] Fix build on arm-linux community triplet#13375

Merged
ras0219-msft merged 3 commits intomicrosoft:masterfrom
FranciscoPombal:fix_libtorrent
Sep 10, 2020
Merged

[libtorrent] Fix build on arm-linux community triplet#13375
ras0219-msft merged 3 commits intomicrosoft:masterfrom
FranciscoPombal:fix_libtorrent

Conversation

@FranciscoPombal
Copy link
Copy Markdown
Contributor

Tested on a Raspberry Pi 4 running the latest stable release of Raspbian/Raspberry PI OS (32-bit).

No additional features were tested, just the basic baseline package.

@FranciscoPombal
Copy link
Copy Markdown
Contributor Author

CI failures are unrelated.

@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 7, 2020
@NancyLi1013
Copy link
Copy Markdown
Contributor

Hi @FranciscoPombal
Thanks for this PR.
Have you tested if these features can work fine?

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@FranciscoPombal
Copy link
Copy Markdown
Contributor Author

@NancyLi1013

Have you tested if these features can work fine?

I haven't tested any additional features, I fixed the baseline installation: vcpkg install libtorrent:arm-linux. In the future I will try out the features and submit follow-up PRs (or an issue report) if needed.

@NancyLi1013 NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Sep 8, 2020
Copy link
Copy Markdown
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once my suggestion is applied.

Thanks for the PR!

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
@ras0219-msft ras0219-msft merged commit 18ab4b7 into microsoft:master Sep 10, 2020
@ras0219-msft
Copy link
Copy Markdown
Contributor

Thanks again!

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Sep 10, 2020
[libtorrent] Fix build on arm-linux community triplet (microsoft#13375)
@FranciscoPombal FranciscoPombal deleted the fix_libtorrent branch September 10, 2020 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants