[d3dx12] Add new port#13360
Merged
ras0219-msft merged 6 commits intomicrosoft:masterfrom Sep 11, 2020
mteterel:d3dx12
Merged
Conversation
NancyLi1013
added
the
category:new-port
NancyLi1013
suggested changes
Sep 7, 2020
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Use the correct d3dx12.h that does not require the very latest Windows SDK
NancyLi1013
reviewed
Sep 8, 2020
NancyLi1013
approved these changes
Sep 8, 2020
NancyLi1013
added
info:needs-maintainer-attention
ras0219-msft
requested changes
Sep 9, 2020
Contributor
ras0219-msft
left a comment
ras0219-msft
left a comment
There was a problem hiding this comment.
Thanks for the PR!
LGTM once my comments are addressed.
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Contributor
|
Also needs to update hash value. CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:102 (message): File does not have expected hash: |
NancyLi1013
suggested changes
Sep 11, 2020
NancyLi1013
approved these changes
Sep 11, 2020
ras0219-msft
approved these changes
Sep 11, 2020
Contributor
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New port: d3dx12 (https://github.com/microsoft/DirectX-Graphics-Samples/tree/master/Libraries/D3DX12)
For convenience purposes.