-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[qt-advanced-docking-system] update to 3.6.1 #13340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6aa76db
update to 3.6.1
stijnherfst 5941d2f
remove unneeded changes
stijnherfst 952fbc9
fix qt5-x11extras linux dependency
stijnherfst 182e0f5
add dependency for osx
stijnherfst 0afe663
make requested changes
stijnherfst 6b9694a
change hash
stijnherfst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| Source: qt-advanced-docking-system | ||
| Version: 3.2.5-2 | ||
| Build-Depends: qt5-base[core], zlib, bzip2 | ||
| Version: 3.6.1 | ||
| Build-Depends: qt5-base[core], qt5-x11extras (!windows), zlib, bzip2 | ||
| Description: Create customizable layouts using an advanced window docking system similar to what is found in many popular IDEs such as Visual Studio | ||
| Homepage: https://github.com/githubuser0xFFFF/Qt-Advanced-Docking-System |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,47 +1,13 @@ | ||
| diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
| index 578dfc1..a4c9460 100644 | ||
| --- a/CMakeLists.txt | ||
| +++ b/CMakeLists.txt | ||
| @@ -70,7 +70,7 @@ if("${CMAKE_SIZEOF_VOID_P}" STREQUAL "4") | ||
| else() | ||
| set(ads_PlatformDir "x64") | ||
| endif() | ||
| -if(BUILD_STATIC) | ||
| +if(NOT BUILD_SHARED_LIBS) | ||
| add_library(qtadvanceddocking STATIC ${ads_SRCS}) | ||
| target_compile_definitions(qtadvanceddocking PUBLIC ADS_STATIC) | ||
| else() | ||
| @@ -88,7 +88,7 @@ install(FILES | ||
| COMPONENT license | ||
| ) | ||
| install(TARGETS qtadvanceddocking | ||
| - EXPORT adsTargets | ||
| + EXPORT qt-advanced-docking-systemConfig | ||
| RUNTIME DESTINATION bin | ||
| LIBRARY DESTINATION lib | ||
| ARCHIVE DESTINATION lib | ||
| @@ -100,14 +100,8 @@ write_basic_package_version_file("adsConfigVersion.cmake" | ||
| VERSION ${ads_VERSION} | ||
| COMPATIBILITY SameMajorVersion | ||
| ) | ||
| -install(EXPORT adsTargets | ||
| - FILE adsTargets.cmake | ||
| - NAMESPACE ads:: | ||
| - DESTINATION lib/cmake/ads | ||
| -) | ||
| -install(FILES "adsConfig.cmake" "${CMAKE_BINARY_DIR}/adsConfigVersion.cmake" | ||
| - DESTINATION lib/cmake/ads | ||
| -) | ||
| + | ||
| +install(EXPORT qt-advanced-docking-systemConfig NAMESPACE qt-advanced-docking-system:: DESTINATION share/qt-advanced-docking-system) | ||
|
|
||
| target_include_directories(qtadvanceddocking PUBLIC | ||
| "$<BUILD_INTERFACE:${ads_INCLUDE}>" | ||
| @@ -117,7 +111,6 @@ target_link_libraries(qtadvanceddocking PUBLIC ${ads_LIBS}) | ||
| target_compile_definitions(qtadvanceddocking PRIVATE ${ads_COMPILE_DEFINE}) | ||
| set_target_properties(qtadvanceddocking PROPERTIES | ||
| VERSION ${ads_VERSION} | ||
| - EXPORT_NAME "QtAdvancedDockingSystem" | ||
| ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${ads_PlatformDir}/lib" | ||
| LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${ads_PlatformDir}/lib" | ||
| RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${ads_PlatformDir}/bin" | ||
| diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt | ||
| index 0bd721d..4848c5f 100644 | ||
| --- a/src/CMakeLists.txt | ||
| +++ b/src/CMakeLists.txt | ||
| @@ -52,7 +52,7 @@ if (UNIX) | ||
| set(ads_SRCS linux/FloatingWidgetTitleBar.cpp ${ads_SRCS}) | ||
| set(ads_HEADERS linux/FloatingWidgetTitleBar.h ${ads_HEADERS}) | ||
| endif() | ||
| -if(BUILD_STATIC) | ||
| +if(NOT BUILD_SHARED_LIBS) | ||
| add_library(qtadvanceddocking STATIC ${ads_SRCS} ${ads_HEADERS}) | ||
| target_compile_definitions(qtadvanceddocking PUBLIC ADS_STATIC) | ||
| else() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
| index 94fdb8d..6febea2 100644 | ||
| --- a/CMakeLists.txt | ||
| +++ b/CMakeLists.txt | ||
| @@ -1,11 +1,6 @@ | ||
| cmake_minimum_required(VERSION 3.5) | ||
| set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules ${CMAKE_MODULE_PATH}) | ||
| -include(GetGitRevisionDescription) | ||
| -git_describe(GitTagVersion --tags) | ||
| -string(REGEX REPLACE "^([0-9]+)\\..*" "\\1" VERSION_MAJOR "${GitTagVersion}") | ||
| -string(REGEX REPLACE "^[0-9]+\\.([0-9]+).*" "\\1" VERSION_MINOR "${GitTagVersion}") | ||
| -string(REGEX REPLACE "^[0-9]+\\.[0-9]+\\.([0-9]+).*" "\\1" VERSION_PATCH "${GitTagVersion}") | ||
| -set(VERSION_SHORT "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}") | ||
| + | ||
| project(QtADS LANGUAGES CXX VERSION ${VERSION_SHORT}) | ||
| option(BUILD_STATIC "Build the static library" OFF) | ||
| option(BUILD_EXAMPLES "Build the examples" ON) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 0 additions & 19 deletions
19
ports/qt-advanced-docking-system/skip_license_install.patch
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.