Skip to content

[sdl2pp] Update to 0.16.1 and fix find_package error#13300

Merged
strega-nil merged 3 commits intomicrosoft:masterfrom
LilyWangL:dev/Lily/issue13271
Nov 9, 2020
Merged

[sdl2pp] Update to 0.16.1 and fix find_package error#13300
strega-nil merged 3 commits intomicrosoft:masterfrom
LilyWangL:dev/Lily/issue13271

Conversation

@LilyWangL
Copy link
Contributor

Describe the pull request

  • What does your PR fix? Fixes [SDL2PP] How do I build SDL2PP? #13271
    Sdl2pp provide FindSDL2PP.cmake, add vcpkg-cmake-wrapper.cmake to set CMAKE_MODULE_PATH. Fix find_package(SDL2PP REQUIRED) error:
By not providing "FindSDL2PP.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "SDL2PP", but
  CMake did not find one.

  Could not find a package configuration file provided by "SDL2PP" with any
  of the following names:

    SDL2PPConfig.cmake
    sdl2pp-config.cmake

@LilyWangL LilyWangL added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Sep 2, 2020
@LilyWangL LilyWangL marked this pull request as ready for review November 4, 2020 08:33
@LilyWangL LilyWangL changed the title [sdl2pp] Fix find_package error [sdl2pp] Update to 0.16.1 and fix find_package error Nov 4, 2020
@LilyWangL LilyWangL requested a review from JackBoosY November 5, 2020 02:20
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 5, 2020
@BillyONeal
Copy link
Member

I'm unsure about the vcpkg_cmake_wrapper for the same reasons as in #14292, I asked some other folks to comment.

@JackBoosY JackBoosY added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Nov 6, 2020
@BillyONeal
Copy link
Member

@JackBoosY It probably doesn't require the author to respond, only a more competent vcpkg maintainer than I

@JackBoosY JackBoosY added requires:discussion info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Nov 9, 2020
@strega-nil strega-nil merged commit 4ebf188 into microsoft:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SDL2PP] How do I build SDL2PP?

4 participants