[vcpkg] Fix compile on gcc 6#13290
Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom Sep 4, 2020
Merged
Conversation
strega-nil
added
category:vcpkg-bug
strega-nil
force-pushed
the
fix-compile-on-gcc-6
branch
from
912be99 to
379f25d
Compare
strega-nil
removed
the
depends:different-pr
Member
|
Stupid question: Can you name these constants outside of the files you declared them in here? And should these constants even be in headers at all? |
Contributor
Author
|
@BillyONeal yes, and yes. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BillyONeal
approved these changes
Sep 3, 2020
Member
|
:sigh: I still hate named-constants-with-content-identical-to-the-named-constant but this doesn't change that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #13038Tested with g++ 6.5.0 on Ubuntu 18.04.