Skip to content

[bigint/zxing-cpp] Adapter xcode 5.1.1 and set it as a dependency of zxing-cpp#13129

Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/12532
Aug 28, 2020
Merged

[bigint/zxing-cpp] Adapter xcode 5.1.1 and set it as a dependency of zxing-cpp#13129
BillyONeal merged 3 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/12532

Conversation

@JackBoosY
Copy link
Contributor

#12532 pipeline test reported error:

/Volumes/data/installed/x64-osx/include/bigint/BigUnsigned.hh:23:24: error: ISO C++11 does not allow access declarations; use using declarations instead
        NumberlikeArray<Blk>::N;
                              ^
        using 
/Volumes/data/installed/x64-osx/include/bigint/BigUnsigned.hh:87:24: error: ISO C++11 does not allow access declarations; use using declarations instead
        NumberlikeArray<Blk>::getCapacity;
                              ^
        using 
/Volumes/data/installed/x64-osx/include/bigint/BigUnsigned.hh:88:24: error: ISO C++11 does not allow access declarations; use using declarations instead
        NumberlikeArray<Blk>::getLength;
                              ^
        using 
3 errors generated.

This is because port zxing-cpp uses the built-in source bigint, and because port bigint is built before port zxing-cpp, resulting in port zxing-cpp using port bigint header files.
So I use the modification of zxing-cpp to adapt bigint to xcode 5.1.1.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-bug The issue is with a library, which is something the port should already support info:internal labels Aug 25, 2020
@JackBoosY JackBoosY requested a review from PhoebeHui August 26, 2020 07:37
@JackBoosY JackBoosY marked this pull request as ready for review August 26, 2020 07:37
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 26, 2020
@BillyONeal BillyONeal merged commit 9211f80 into microsoft:master Aug 28, 2020
@JackBoosY JackBoosY deleted the dev/jack/12532 branch August 28, 2020 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants