Skip to content

[vcpkg] Add Forward Declarations (originally by @cngzhnp)#12985

Merged
BillyONeal merged 5 commits intomicrosoft:masterfrom
strega-nil:cngzhnp/fix_forward_declarations
Aug 19, 2020
Merged

[vcpkg] Add Forward Declarations (originally by @cngzhnp)#12985
BillyONeal merged 5 commits intomicrosoft:masterfrom
strega-nil:cngzhnp/fix_forward_declarations

Conversation

@strega-nil
Copy link
Contributor

Based on @cngzhnp's changes in #12836; I prefer this version of the changes, since there's no copy-pasting of forward declarations.

@strega-nil strega-nil changed the title [vcpkg] Add Forward Declarations [vcpkg] Add Forward Declarations (originally by @cngzhnp) Aug 18, 2020
@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal labels Aug 19, 2020
@strega-nil
Copy link
Contributor Author

strega-nil commented Aug 19, 2020

@BillyONeal made the changes you wanted :) (and also deleted Util::copy, which I feel like has a similar problem to Util::unused, and which was only used in one place)

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

@cngzhnp and @strega-nil Thanks for your contribution!

@BillyONeal BillyONeal merged commit 5e164e3 into microsoft:master Aug 19, 2020
remz1337 pushed a commit to remz1337/vcpkg that referenced this pull request Aug 23, 2020
…12985)

Co-authored-by: cngzhnp <cengizhanpasaoglu@gmail.com>
@strega-nil strega-nil deleted the cngzhnp/fix_forward_declarations branch September 10, 2020 21:21
strega-nil added a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
…12985)

Co-authored-by: cngzhnp <cengizhanpasaoglu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants