Skip to content

[libtorrent] minor version bump and python patch adjustment#12946

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
FranciscoPombal:master
Aug 21, 2020
Merged

[libtorrent] minor version bump and python patch adjustment#12946
BillyONeal merged 1 commit intomicrosoft:masterfrom
FranciscoPombal:master

Conversation

@FranciscoPombal
Copy link
Copy Markdown
Contributor

@FranciscoPombal FranciscoPombal commented Aug 17, 2020

Previously: #12768

  • Python patch was adjusted to apply once again. A recent minor change to the upstream files had made it incompatible.
  • Include changes from recent commits to RC_1_2 Bump to 1.2.9, which notably includes an important fix for the logic that selects the C++ version used during compilation.

Tested all features and they work fine.

@LilyWangL LilyWangL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Aug 17, 2020
@FranciscoPombal
Copy link
Copy Markdown
Contributor Author

Please consider waiting a bit before merging this. 1.2.9 is going to be released sooner than I expected, so it's probably worth it to wait a bit and bump directly to the 1.2.9 tag instead. Apologies for the inconvenience.

@LilyWangL LilyWangL marked this pull request as draft August 19, 2020 02:50
@LilyWangL LilyWangL added depends:upstream-changes Waiting on a change to the upstream project and removed requires:author-response labels Aug 19, 2020
@FranciscoPombal
Copy link
Copy Markdown
Contributor Author

@LilyWangL This is ready now.

@FranciscoPombal FranciscoPombal marked this pull request as ready for review August 20, 2020 22:32
@LilyWangL LilyWangL removed the depends:upstream-changes Waiting on a change to the upstream project label Aug 21, 2020
@LilyWangL LilyWangL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 21, 2020
@BillyONeal BillyONeal merged commit 5e7e48d into microsoft:master Aug 21, 2020
@BillyONeal
Copy link
Copy Markdown
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants