-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[harfbuzz] Use meson and update to 2.7.0 #12860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
862f1be
[harfbuzz] Use meson
ebraminio bb5e5d1
[harfbuzz] Add config file for CMake
vejmartin aa3053e
[harfbuzz,pango] Remove glib option for harfbuzz
vejmartin 3ba27c6
[libass,libmupdf,qt5-base,skia] Fix for harfbuzz
vejmartin b40f047
Back out meson edit already applied in https://github.com/microsoft/v…
BillyONeal 66ca074
[harfbuzz] Fixup pkgconfig
vejmartin ea449ce
[libass] Bump port version
vejmartin cf28763
Revert "[libass,libmupdf,qt5-base,skia] Fix for harfbuzz"
vejmartin 41cd97c
[harfbuzz] Update to 2.7.4
vejmartin 698de95
Merge branch 'master' of https://github.com/microsoft/vcpkg into harf…
839fc80
update baseline record
30041c3
Restore glib feature for harfbuzz and remove vagrant change
vejmartin 6a95f55
Update port version
vejmartin 168977b
Merge branch 'master' into harfbuzz
vejmartin cfc3317
Change over to manifests
vejmartin 747adf3
Update port version
vejmartin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| if(TARGET harfbuzz) | ||
| return() | ||
| endif() | ||
|
|
||
| add_library(harfbuzz INTERFACE IMPORTED GLOBAL) | ||
| add_library(harfbuzz::harfbuzz ALIAS harfbuzz) | ||
|
|
||
| find_library(HARFBUZZ_LIBRARY_DEBUG NAMES harfbuzz PATHS "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/debug" PATH_SUFFIXES lib NO_DEFAULT_PATH) | ||
| if(HARFBUZZ_LIBRARY_DEBUG) | ||
| target_link_libraries(harfbuzz INTERFACE $<$<CONFIG:DEBUG>:${HARFBUZZ_LIBRARY_DEBUG}>) | ||
| endif() | ||
|
|
||
| find_library(HARFBUZZ_LIBRARY_RELEASE NAMES harfbuzz PATHS "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}" PATH_SUFFIXES lib NO_DEFAULT_PATH) | ||
| if(HARFBUZZ_LIBRARY_RELEASE) | ||
| target_link_libraries(harfbuzz INTERFACE $<$<NOT:$<CONFIG:DEBUG>>:${HARFBUZZ_LIBRARY_RELEASE}>) | ||
| endif() | ||
|
|
||
| set(HARFBUZZ_FEATURES @FEATURES@) | ||
|
|
||
| if(APPLE) | ||
| find_library(APPLICATIONSERVICES_LIBRARY ApplicationServices) | ||
| target_link_libraries(harfbuzz INTERFACE ${APPLICATIONSERVICES_LIBRARY}) | ||
| endif() | ||
|
|
||
| find_package(freetype CONFIG REQUIRED) | ||
| target_link_libraries(harfbuzz INTERFACE freetype) | ||
|
|
||
| if ("graphite2" IN_LIST HARFBUZZ_FEATURES) | ||
| find_library(GRAPHITE2_LIBRARY_DEBUG NAMES graphite2 PATHS "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/debug" PATH_SUFFIXES lib NO_DEFAULT_PATH) | ||
| if(GRAPHITE2_LIBRARY_DEBUG) | ||
| target_link_libraries(harfbuzz INTERFACE $<$<CONFIG:DEBUG>:${GRAPHITE2_LIBRARY_DEBUG}>) | ||
| endif() | ||
|
|
||
| find_library(GRAPHITE2_LIBRARY_RELEASE NAMES graphite2 PATHS "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}" PATH_SUFFIXES lib NO_DEFAULT_PATH) | ||
| if(GRAPHITE2_LIBRARY_RELEASE) | ||
| target_link_libraries(harfbuzz INTERFACE $<$<NOT:$<CONFIG:DEBUG>>:${GRAPHITE2_LIBRARY_RELEASE}>) | ||
| endif() | ||
| endif() | ||
|
|
||
| if ("glib" IN_LIST HARFBUZZ_FEATURES) | ||
| find_library(GLIB_LIBRARY_DEBUG NAMES glib glib-2.0 PATHS "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/debug" PATH_SUFFIXES lib NO_DEFAULT_PATH) | ||
| if(GLIB_LIBRARY_DEBUG) | ||
| target_link_libraries(harfbuzz INTERFACE $<$<CONFIG:DEBUG>:${GLIB_LIBRARY_DEBUG}>) | ||
| endif() | ||
|
|
||
| find_library(GLIB_LIBRARY_RELEASE NAMES glib glib-2.0 PATHS "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}" PATH_SUFFIXES lib NO_DEFAULT_PATH) | ||
| if(GLIB_LIBRARY_RELEASE) | ||
| target_link_libraries(harfbuzz INTERFACE $<$<NOT:$<CONFIG:DEBUG>>:${GLIB_LIBRARY_RELEASE}>) | ||
| endif() | ||
| endif() | ||
|
|
||
| if ("icu" IN_LIST HARFBUZZ_FEATURES) | ||
| find_package(ICU 61 COMPONENTS uc REQUIRED) | ||
| target_link_libraries(harfbuzz INTERFACE ICU::uc) | ||
| endif() | ||
|
|
||
| get_filename_component(_INSTALL_DIR "${CMAKE_CURRENT_LIST_DIR}/../../" ABSOLUTE) | ||
| target_include_directories(harfbuzz INTERFACE ${_INSTALL_DIR}/include/harfbuzz) | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,62 +1,43 @@ | ||
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO harfbuzz/harfbuzz | ||
| REF 9c98b2b9a9e43669c5e2b37eaa41b1e07de1ede3 # 2.7.2 | ||
| SHA512 00b61034abce61370a7ff40bf5aa80bc1b3557d1f978ef91725fc30b34c4c00c682a3b9c99233e7e52d579b60694a1ba08714d5c9b01ad13e9fd76828facc720 | ||
| REF 7236c7e29cef1c2d76c7a284c5081ff4d3aa1127 # 2.7.4 | ||
| SHA512 d231a788ea4e52231d4c363c1eca76424cb82ed0952b5c24d0b082e88b3dddbda967e7fffe67fffdcb22c7ebfbf0ec923365eb4532be772f2e61fa7d29b51998 | ||
| HEAD_REF master | ||
| PATCHES | ||
| 0001-fix-cmake-export.patch | ||
| 0002-fix-uwp-build.patch | ||
| 0003-remove-broken-test.patch | ||
| # This patch is required for propagating the full list of static dependencies from freetype | ||
| find-package-freetype-2.patch | ||
| # This patch is required for propagating the full list of dependencies from glib | ||
| glib-cmake.patch | ||
| fix_include.patch | ||
| icu.patch | ||
| ) | ||
|
|
||
| file(READ ${SOURCE_PATH}/CMakeLists.txt _contents) | ||
|
|
||
| if("${_contents}" MATCHES "include \\(FindFreetype\\)") | ||
| message(FATAL_ERROR "Harfbuzz's cmake must not directly include() FindFreetype.") | ||
| endif() | ||
|
|
||
| if("${_contents}" MATCHES "find_library\\(GLIB_LIBRARIES") | ||
| message(FATAL_ERROR "Harfbuzz's cmake must not directly find_library() glib.") | ||
| endif() | ||
|
|
||
| vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS | ||
| icu HB_HAVE_ICU | ||
| graphite2 HB_HAVE_GRAPHITE2 | ||
| glib HB_HAVE_GLIB | ||
| icu icu | ||
| graphite2 graphite | ||
| glib glib | ||
| ) | ||
|
|
||
| vcpkg_configure_cmake( | ||
| string(REPLACE "=ON" "=enabled" FEATURE_OPTIONS "${FEATURE_OPTIONS}") | ||
| string(REPLACE "=OFF" "=disabled" FEATURE_OPTIONS "${FEATURE_OPTIONS}") | ||
|
|
||
| vcpkg_configure_meson( | ||
| SOURCE_PATH ${SOURCE_PATH} | ||
| PREFER_NINJA | ||
| OPTIONS ${FEATURE_OPTIONS} | ||
| -DHB_HAVE_FREETYPE=ON | ||
| -DHB_BUILD_TESTS=OFF | ||
| OPTIONS_DEBUG | ||
| -DSKIP_INSTALL_HEADERS=ON | ||
| -Dfreetype=enabled | ||
| -Dgobject=disabled | ||
| -Dcairo=disabled | ||
| -Dfontconfig=disabled | ||
| -Dintrospection=disabled | ||
| -Ddocs=disabled | ||
| -Dtests=disabled | ||
| -Dbenchmark=disabled | ||
| ) | ||
|
|
||
| vcpkg_install_cmake() | ||
| vcpkg_fixup_cmake_targets() | ||
|
|
||
| vcpkg_install_meson() | ||
| vcpkg_copy_pdbs() | ||
| vcpkg_fixup_pkgconfig() | ||
|
|
||
| if ("glib" IN_LIST FEATURES) | ||
| # Propagate dependency on glib downstream | ||
| file(READ "${CURRENT_PACKAGES_DIR}/share/harfbuzz/harfbuzzConfig.cmake" _contents) | ||
| file(WRITE "${CURRENT_PACKAGES_DIR}/share/harfbuzz/harfbuzzConfig.cmake" " | ||
| include(CMakeFindDependencyMacro) | ||
| find_dependency(unofficial-glib CONFIG) | ||
|
|
||
| ${_contents} | ||
| ") | ||
| endif() | ||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/lib/cmake") | ||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/lib/cmake") | ||
JackBoosY marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| configure_file("${CMAKE_CURRENT_LIST_DIR}/harfbuzzConfig.cmake.in" | ||
| "${CURRENT_PACKAGES_DIR}/share/${PORT}/harfbuzzConfig.cmake" @ONLY) | ||
|
|
||
| # Handle copyright | ||
| file(INSTALL ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| { | ||
| "name": "harfbuzz", | ||
| "version-string": "2.7.4", | ||
| "description": "HarfBuzz OpenType text shaping engine", | ||
| "homepage": "https://github.com/harfbuzz/harfbuzz", | ||
| "dependencies": [ | ||
| { | ||
| "name": "freetype", | ||
| "default-features": false | ||
| }, | ||
| { | ||
| "name": "gettext", | ||
| "platform": "osx" | ||
| } | ||
| ], | ||
| "features": { | ||
| "glib": { | ||
| "description": "Glib Unicode callbacks support", | ||
| "dependencies": [ | ||
| "glib" | ||
| ] | ||
| }, | ||
| "graphite2": { | ||
| "description": "Graphite2 shaper support", | ||
| "dependencies": [ | ||
| "graphite2" | ||
| ] | ||
| }, | ||
| "icu": { | ||
| "description": "icu support for harfbuzz", | ||
| "dependencies": [ | ||
| "icu" | ||
| ] | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.