Skip to content

[raylib] Fix the feature issue#12783

Merged
strega-nil merged 1 commit intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/raylib
Aug 7, 2020
Merged

[raylib] Fix the feature issue#12783
strega-nil merged 1 commit intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/raylib

Conversation

@PhoebeHui
Copy link
Copy Markdown
Contributor

Fixes #12707

The original feature 'non-audio' added, however, the ${FEATURE_OPTIONS} wasn't added to cmake, then related symble doesn't export, that cause the link errors when use the raylib.

Change it build as default feature now.

Test:

#include "raylib.h"

int main(void)
{
	const int screenWidth = 800;
	const int screenHeight = 450;

	InitWindow(screenHeight, screenHeight, "raylib example");
	InitAudioDevice();
	Music music = LoadMusicStream("woop.mp3");
	PlayMusicStream(music);
}

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Aug 6, 2020
@PhoebeHui PhoebeHui marked this pull request as draft August 7, 2020 01:50
@PhoebeHui
Copy link
Copy Markdown
Contributor Author

cc @myd7349

@PhoebeHui PhoebeHui marked this pull request as ready for review August 7, 2020 02:22
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 7, 2020
@JackBoosY
Copy link
Copy Markdown
Contributor

When using vcpkg_check_features, FEATURE_OPTIONS must be passed to vcpkg_configure_cmake. This is very easy for us to ignore this point. I think we should improve vcpkg_configure_cmake.

@strega-nil strega-nil merged commit 8121b4e into microsoft:master Aug 7, 2020
@PhoebeHui PhoebeHui deleted the dev/Phoebe/raylib branch August 11, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raylib's audio module not working

3 participants