Skip to content

[curl] Fix tools#12758

Merged
strega-nil merged 1 commit intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-curl
Aug 7, 2020
Merged

[curl] Fix tools#12758
strega-nil merged 1 commit intomicrosoft:masterfrom
NancyLi1013:dev/NancyLi/fix-curl

Conversation

@NancyLi1013
Copy link
Copy Markdown
Contributor

vcpkg_copy_tool_dependencies cannot copy dll files to the destinations, so update it as vcpkg_copy_tools().

Note: feature tools has passed with the following triplets:

  • x86-windows
  • x64-windows

Other features are no need to test.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Aug 5, 2020
@cenit
Copy link
Copy Markdown
Contributor

cenit commented Aug 5, 2020

Also, one less patch to maintain, thanks to a proper usage of vcpkg built-ins!

@NancyLi1013 NancyLi1013 marked this pull request as ready for review August 6, 2020 01:28
@NancyLi1013
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Copy Markdown
Contributor

Related: #12276.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 7, 2020
@strega-nil strega-nil merged commit 23fcc57 into microsoft:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail to execute curl.exe after building curl[tool]:x64-windows

4 participants