[vcpkg] Add swig acquire by marekr · Pull Request #12697 · microsoft/vcpkg

marekr · 2020-08-02T14:40:22Z

SWIG is a interface compiler that allows binding C and C++ to scripting languages like Python, Ruby, Tcl and others. It's purely a compile-time tool to generate the bindings agaisnt your code.

I have a future port that will use this however, even end-user applications may find it handy to just vcpkg_find_package_acquire_swig for windows instead of needing a separate system install.

Neumann-A · 2020-08-02T14:48:46Z

also included in #11208

MVoz · 2020-08-02T14:48:59Z

add SWIG_VERSION ?

  elseif(VAR MATCHES "SWIG")
    set(PROGNAME swig)
    set(SWIG_VERSION "4.0.2")
    set(PATHS "${DOWNLOADS}/tools/swig/swigwin-${SWIG_VERSION}")${SWIG_VERSION}
    set(URL 
      "https://jaist.dl.sourceforge.net/project/swig/swigwin/swigwin-${SWIG_VERSION}/swigwin-${SWIG_VERSION}.zip"
      "https://sourceforge.net/projects/swig/files/swigwin/swigwin-${SWIG_VERSION}/swigwin-${SWIG_VERSION}.zip/download"
    )
    set(ARCHIVE "swigwin-${SWIG_VERSION}.zip")
    set(HASH b8f105f9b9db6acc1f6e3741990915b533cd1bc206eb9645fd6836457fd30789b7229d2e3219d8e35f2390605ade0fbca493ae162ec3b4bc4e428b57155db03d)

marekr · 2020-08-02T14:54:58Z

add SWIG_VERSION ?

  elseif(VAR MATCHES "SWIG")
    set(PROGNAME swig)
    set(SWIG_VERSION "4.0.2")
    set(PATHS "${DOWNLOADS}/tools/swig/swigwin-${SWIG_VERSION}")${SWIG_VERSION}
    set(URL 
      "https://jaist.dl.sourceforge.net/project/swig/swigwin/swigwin-${SWIG_VERSION}/swigwin-${SWIG_VERSION}.zip"
      "https://sourceforge.net/projects/swig/files/swigwin/swigwin-${SWIG_VERSION}/swigwin-${SWIG_VERSION}.zip/download"
    )
    set(ARCHIVE "swigwin-${SWIG_VERSION}.zip")
    set(HASH b8f105f9b9db6acc1f6e3741990915b533cd1bc206eb9645fd6836457fd30789b7229d2e3219d8e35f2390605ade0fbca493ae162ec3b4bc4e428b57155db03d)

Yea actually that'll be better, done

Neumann-A · 2020-08-02T14:56:43Z

scripts/cmake/vcpkg_find_acquire_program.cmake

+  elseif(VAR MATCHES "SWIG")
+    set(PROGNAME swig)
+    set(PATHS ${DOWNLOADS}/tools/swig/swigwin-4.0.2)
+    set(URL "https://sourceforge.net/projects/swig/files/swigwin/swigwin-4.0.2/swigwin-4.0.2.zip/download")
+    set(ARCHIVE "swigwin-4.0.2.zip")
+    set(HASH b8f105f9b9db6acc1f6e3741990915b533cd1bc206eb9645fd6836457fd30789b7229d2e3219d8e35f2390605ade0fbca493ae162ec3b4bc4e428b57155db03d)


Suggested change

elseif(VAR MATCHES "SWIG")

set(PROGNAME swig)

set(PATHS ${DOWNLOADS}/tools/swig/swigwin-4.0.2)

set(URL "https://sourceforge.net/projects/swig/files/swigwin/swigwin-4.0.2/swigwin-4.0.2.zip/download")

set(ARCHIVE "swigwin-4.0.2.zip")

set(HASH b8f105f9b9db6acc1f6e3741990915b533cd1bc206eb9645fd6836457fd30789b7229d2e3219d8e35f2390605ade0fbca493ae162ec3b4bc4e428b57155db03d)

elseif(VAR MATCHES "SWIG")

set(VERSION 4.0.2)

set(PROGNAME swig)

if(CMAKE_HOST_WIN32)

set(URL "https://sourceforge.net/projects/swig/files/swigwin/swigwin-${VERSION}/swigwin-${VERSION}.zip/download")

set(ARCHIVE "swigwin-${VERSION}.zip")

set(HASH b8f105f9b9db6acc1f6e3741990915b533cd1bc206eb9645fd6836457fd30789b7229d2e3219d8e35f2390605ade0fbca493ae162ec3b4bc4e428b57155db03d)

set(SUBDIR "swigwin-${VERSION}")

set(PATHS "${DOWNLOADS}/tools/swig/${SUBDIR}/${SUBDIR}")

else()

set(_vfa_SUPPORTED TRUE)

set(URL https://sourceforge.net/projects/swig/files/swig/swig-${VERSION}/swig-${VERSION}.tar.gz/download)

set(ARCHIVE "swig-${VERSION}.tar.gz")

set(HASH 05e7da70ce6d9a733b96c0bcfa3c1b82765bd859f48c74759bbf4bb1467acb1809caa310cba5e2b3280cd704fca249eaa0624821dffae1d2a75097c7f55d14ed)

set(SUBDIR "swig-${VERSION}")

set(PATHS "${DOWNLOADS}/tools/swig/${SUBDIR}")

endif()

set(SOURCEFORGE_ARGS

REPO swig

FILENAME "${ARCHIVE}"

SHA512 "${HASH}"

NO_REMOVE_ONE_LEVEL

WORKING_DIRECTORY "${DOWNLOADS}/tools/swig"

)

What's up with the #not used path?

I didn't test SWIG+ITK for the python bindings or it was using swig provided by the system somehow. Cannot remember anymore. Removed the comment

I can't apply your changes as its apparently out of date

MVoz · 2020-08-02T14:58:58Z

@BillyONeal

Remove-Item : Cannot remove item D:\downloads\tools\msys2\msys64\usr\bin\msys-2.0.dll: Access to the path

'msys-2.0.dll' is denied.
At C:\agent\_work\1\s\scripts\azure-pipelines\windows\initialize-environment.ps1:46 char:5

scripts/cmake/vcpkg_find_acquire_program.cmake

Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com>

MVoz · 2020-08-02T17:27:29Z

@Neumann-A

?


   if(CMAKE_HOST_WIN32)
...
       set(PATHS "${DOWNLOADS}/tools/swig/${SUBDIR}/${SUBDIR}")
...

...\vcpkg\downloads\tools\swig\swigwin-4.0.2\swigwin-4.0.2\swig.exe

enough of this, why so many extra nested folders?
set(PATHS "${DOWNLOADS}/tools/swig/${SUBDIR}")

...\vcpkg\downloads\tools\swig\swigwin-4.0.2

Neumann-A · 2020-08-02T17:31:57Z

Please fix it if you know how and where. It the strange zip extraction which creates the subfolders. Paths is just a hint where to find it.

MVoz · 2020-08-02T17:43:53Z

   if(CMAKE_HOST_WIN32)
...
       set(PATHS "${DOWNLOADS}/tools/swig/${SUBDIR}/${SUBDIR}")
...

Neumann-A · 2020-08-03T06:00:47Z

Can be closed ITK PR was merged.

Add swig as vcpkg_find_acquire_program option

5eae522

Add SWIG_VERSION

0b1fcf2

Neumann-A reviewed Aug 2, 2020

View reviewed changes

scripts/cmake/vcpkg_find_acquire_program.cmake Outdated Show resolved Hide resolved

marekr and others added 2 commits August 2, 2020 11:37

Update scripts/cmake/vcpkg_find_acquire_program.cmake

20a643a

Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com>

Fix spacing

13cdb76

PhoebeHui assigned JackBoosY Aug 3, 2020

JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Aug 3, 2020

marekr closed this Aug 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vcpkg] Add swig acquire#12697

[vcpkg] Add swig acquire#12697
marekr wants to merge 4 commits intomicrosoft:masterfrom
marekr:swig

marekr commented Aug 2, 2020 •

edited

Loading

Uh oh!

Neumann-A commented Aug 2, 2020

Uh oh!

MVoz commented Aug 2, 2020 •

edited

Loading

Uh oh!

marekr commented Aug 2, 2020 •

edited

Loading

Uh oh!

Neumann-A Aug 2, 2020 •

edited

Loading

Uh oh!

marekr Aug 2, 2020

Uh oh!

Neumann-A Aug 2, 2020

Uh oh!

marekr Aug 2, 2020

Uh oh!

MVoz commented Aug 2, 2020 •

edited

Loading

Uh oh!

Uh oh!

MVoz commented Aug 2, 2020

Uh oh!

Neumann-A commented Aug 2, 2020

Uh oh!

MVoz commented Aug 2, 2020

Uh oh!

Neumann-A commented Aug 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

-  elseif(VAR MATCHES "SWIG")
-    set(PROGNAME swig)
-    set(PATHS ${DOWNLOADS}/tools/swig/swigwin-4.0.2)
-    set(URL "https://sourceforge.net/projects/swig/files/swigwin/swigwin-4.0.2/swigwin-4.0.2.zip/download")
-    set(ARCHIVE "swigwin-4.0.2.zip")
-    set(HASH b8f105f9b9db6acc1f6e3741990915b533cd1bc206eb9645fd6836457fd30789b7229d2e3219d8e35f2390605ade0fbca493ae162ec3b4bc4e428b57155db03d)
+elseif(VAR MATCHES "SWIG")
+   set(VERSION 4.0.2)
+   set(PROGNAME swig)
+   if(CMAKE_HOST_WIN32)
+       set(URL "https://sourceforge.net/projects/swig/files/swigwin/swigwin-${VERSION}/swigwin-${VERSION}.zip/download")
+       set(ARCHIVE "swigwin-${VERSION}.zip")
+       set(HASH b8f105f9b9db6acc1f6e3741990915b533cd1bc206eb9645fd6836457fd30789b7229d2e3219d8e35f2390605ade0fbca493ae162ec3b4bc4e428b57155db03d)
+       set(SUBDIR "swigwin-${VERSION}")
+       set(PATHS "${DOWNLOADS}/tools/swig/${SUBDIR}/${SUBDIR}")
+   else()
+       set(_vfa_SUPPORTED TRUE)
+       set(URL https://sourceforge.net/projects/swig/files/swig/swig-${VERSION}/swig-${VERSION}.tar.gz/download)
+       set(ARCHIVE "swig-${VERSION}.tar.gz")
+       set(HASH 05e7da70ce6d9a733b96c0bcfa3c1b82765bd859f48c74759bbf4bb1467acb1809caa310cba5e2b3280cd704fca249eaa0624821dffae1d2a75097c7f55d14ed)
+       set(SUBDIR "swig-${VERSION}")
+       set(PATHS "${DOWNLOADS}/tools/swig/${SUBDIR}")
+   endif()
+   set(SOURCEFORGE_ARGS
+       REPO swig
+       FILENAME "${ARCHIVE}"
+       SHA512 "${HASH}"
+       NO_REMOVE_ONE_LEVEL
+       WORKING_DIRECTORY "${DOWNLOADS}/tools/swig"
+    )

Conversation

marekr commented Aug 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neumann-A commented Aug 2, 2020

Uh oh!

MVoz commented Aug 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marekr commented Aug 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neumann-A Aug 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marekr Aug 2, 2020

Choose a reason for hiding this comment

Uh oh!

Neumann-A Aug 2, 2020

Choose a reason for hiding this comment

Uh oh!

marekr Aug 2, 2020

Choose a reason for hiding this comment

Uh oh!

MVoz commented Aug 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

MVoz commented Aug 2, 2020

Uh oh!

Neumann-A commented Aug 2, 2020

Uh oh!

MVoz commented Aug 2, 2020

Uh oh!

Neumann-A commented Aug 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

marekr commented Aug 2, 2020 •

edited

Loading

MVoz commented Aug 2, 2020 •

edited

Loading

marekr commented Aug 2, 2020 •

edited

Loading

Neumann-A Aug 2, 2020 •

edited

Loading

MVoz commented Aug 2, 2020 •

edited

Loading