Skip to content

[vcpkg msys] Fix msys2#12603

Closed
strega-nil wants to merge 4 commits intomicrosoft:masterfrom
strega-nil:fix-msys2
Closed

[vcpkg msys] Fix msys2#12603
strega-nil wants to merge 4 commits intomicrosoft:masterfrom
strega-nil:fix-msys2

Conversation

@strega-nil
Copy link
Contributor

Update to 2020-07-20. Unfortunately, this drops support for building on x86

cc @ras0219-msft @BillyONeal

Update to 2020-07-20. Unfortunately, this drops support for building on x86
@MVoz
Copy link
Contributor

MVoz commented Jul 27, 2020

vcpkg_acquire_msys

3 mirror download

  if(_vam_HOST_ARCHITECTURE STREQUAL "AMD64")
    set(TOOLSUBPATH msys64)
    set(URLS
      "http://repo.msys2.org/distrib/x86_64/msys2-base-x86_64-20200602.tar.xz"
      "https://github.com/msys2/msys2-installer/releases/download/2020-06-02/msys2-base-x86_64-20200602.tar.xz"
      "https://sourceforge.net/projects/msys2/files/Base/x86_64/msys2-base-x86_64-20200602.tar.xz/download"
    )
    set(ARCHIVE "msys2-base-x86_64-20200602.tar.xz")
    set(HASH ea754c9ea9fc7ae7051c15f97f5ee95dc628bf12af3713f941991a6ab3169f4c23767d132fa6640338a449648998dc4013c6f094f7ce2fe44c61caf276caf8c6)
    set(STAMP "initialized-msys2_64.stamp")
  else()
    set(TOOLSUBPATH msys32)
    set(URLS
      "http://repo.msys2.org/distrib/i686/msys2-base-i686-20200517.tar.xz"
      "https://github.com/msys2/msys2-installer/releases/download/2020-05-17/msys2-base-i686-20200517.tar.xz"
    )
    set(ARCHIVE "msys2-base-i686-20200517.tar.xz")
    set(HASH 74786326c07c1cf2b11440cbd7caf947c2a32ebcc2b5bb362301d12327a2108182f57e98c217487db75bf6f0e3a4577291933e025b9b170e37848ec0b51a134c)
    set(STAMP "initialized-msys2_32.stamp")
  endif()

?

@strega-nil
Copy link
Contributor Author

strega-nil commented Jul 27, 2020

@voskrese the sourceforge mirrors are no longer updated, and x86 is no longer supported. I will add the github mirrors tho, thanks!

@microsoft microsoft deleted a comment from BillyONeal Jul 27, 2020
@PhoebeHui PhoebeHui added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jul 28, 2020
@JackBoosY
Copy link
Contributor

But if the host is x86, how should we use msys?

@JackBoosY
Copy link
Contributor

@emptyVoid Ping for review this PR.

@ras0219-msft
Copy link
Contributor

ras0219-msft commented Jul 28, 2020

From https://www.msys2.org/:

MSYS2 requires Windows 7 (64 bit) or newer

Unfortunately, this means that anything requiring msys2 simply can't be used on x86 hosts because it is not supported on those platforms. We should investigate minimizing the number of default features that result in msys2 being invoked.

@emptyVoid
Copy link
Contributor

and x86 is no longer supported

Well, afaiu MSYS2 team have just dropped building x86 installer. MinGW packages are still being updated for both platforms. And vcpkg doesn't really use the x86_64-only MSYS tools and packages.

I'm not sure if this is a good move to forsake all the vcpkg users who are stuck with x86 build servers, though of course I got no idea how many of them are out there.

@cenit
Copy link
Contributor

cenit commented Jul 28, 2020

what about #12467 instead?

@strega-nil
Copy link
Contributor Author

Fixed by #12467 instead

@strega-nil strega-nil closed this Jul 28, 2020
@strega-nil strega-nil deleted the fix-msys2 branch August 2, 2020 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants