[CppAD] Add CppAD port by GiulioRomualdi · Pull Request #12560 · microsoft/vcpkg

GiulioRomualdi · 2020-07-24T12:26:04Z

What does your PR fix? Fixes [New Port Request] CppAD #12522
Which triplets are supported/not supported? Have you updated the CI baseline? All the triplets should be supported.
Does your PR follow the maintainer guide? yes.

@traversaro @S-Dafarra

ports/cppad/portfile.cmake

NancyLi1013 · 2020-07-27T03:06:48Z

/azp run

azure-pipelines · 2020-07-27T03:07:06Z

Azure Pipelines successfully started running 1 pipeline(s).

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

ports/cppad/portfile.cmake

NancyLi1013 · 2020-07-29T01:54:59Z

/azp run

azure-pipelines · 2020-07-29T01:55:07Z

Azure Pipelines successfully started running 1 pipeline(s).

GiulioRomualdi · 2020-07-30T07:43:05Z

I tried to build cppad:x86-windows on a fresh windows installation and I got the following error. @NancyLi1013 could you please give me an explanation of why this happening?

Should I remove PREFER_NINJA from vcpkg_configure_cmake when the triplet x86-windows is used?

.\vcpkg.exe install cppad:x86-windows
Computing installation plan...
The following packages will be built and installed:
    cppad[core]:x86-windows
Detecting compiler hash for triplet x86-windows...
Starting package 1/1: cppad:x86-windows
Building package cppad[core]:x86-windows...
Could not locate cached archive: C:\Users\gromualdi\AppData\Local\vcpkg\archives\60\60acc7c8c365356ea3fa728f338186ea7a673064.zip
-- Using cached C:/Users/gromualdi/robot-code/vcpkg/downloads/coin-or-CppAD-20200000.3.tar.gz
-- Cleaning sources at C:/Users/gromualdi/robot-code/vcpkg/buildtrees/cppad/src/20200000.3-2149299b1e.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source C:/Users/gromualdi/robot-code/vcpkg/downloads/coin-or-CppAD-20200000.3.tar.gz
-- Applying patch windows-fix.patch
-- Using source at C:/Users/gromualdi/robot-code/vcpkg/buildtrees/cppad/src/20200000.3-2149299b1e.clean
-- Configuring x86-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
    Command failed: ninja -v
    Working Directory: C:/Users/gromualdi/robot-code/vcpkg/buildtrees/cppad/x86-windows-rel/vcpkg-parallel-configure
    Error code: 1
    See logs for more information:
      C:\Users\gromualdi\robot-code\vcpkg\buildtrees\cppad\config-x86-windows-out.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_cmake.cmake:300 (vcpkg_execute_required_process)
  ports/cppad/portfile.cmake:13 (vcpkg_configure_cmake)
  scripts/ports.cmake:79 (include)

NancyLi1013 · 2020-07-30T09:41:55Z

Could you please provide C:\Users\gromualdi\robot-code\vcpkg\buildtrees\cppad\config-x86-windows-out.log?

GiulioRomualdi · 2020-07-30T10:04:30Z

Could you please provide C:\Users\gromualdi\robot-code\vcpkg\buildtrees\cppad\config-x86-windows-out.log?

This is the file: config-x86-windows-out.log

Here you can find additional files:

According to the fatal error in CMakeError.log:

CheckIncludeFile.c(1): fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory
ninja: build stopped: subcommand failed.

There seems that the error is related to pthread

Thank you very much for your support.

GiulioRomualdi · 2020-07-30T11:26:52Z

On the other hand, the error on x64_osx is caused by

vcpkg/ports/cppad/portfile.cmake

Line 33 in 7803ab5

vcpkg_fixup_pkgconfig()

Indeed the cppad.pc provided by the original library does not contain:

prefix=${pcfiledir}/../..
exec_prefix=${prefix}
includedir=${prefix}/include
libdir=${exec_prefix}/lib

This is an example of the file generated on my PC

 Name:         cppad
 Description:  Differentiation of C++ Algorithms
 Version:      20200000.3
 URL:          http://www.coin-or.org/CppAD
 # Entries set by pkgconfig/CMakeLists.txt file
 Cflags:       -I/home/gromualdi/robot-code/vcpkg/packages/cppad_x64-linux/include
 Libs:         -L/home/gromualdi/robot-code/vcpkg/packages/cppad_x64-linux/lib -lcppad_lib
 Requires:

when vcpkg_fixup_pkgconfig() is called /home/gromualdi/robot-code/vcpkg/packages/cppad_x64-linux/ is substituted with ${prefix}

 Name:         cppad
 Description:  Differentiation of C++ Algorithms
 Version:      20200000.3
 URL:          http://www.coin-or.org/CppAD
 # Entries set by pkgconfig/CMakeLists.txt file
 Cflags:       -I${prefix}/include
 Libs:         -L${prefix}/lib  -lcppad_lib
 Requires:

however, since prefix is not defined. The error is thrown.

Possible solutions are:

remove vcpkg_fixup_pkgconfig()
add a patch for fixing the issue

What do you prefer? @NancyLi1013

traversaro · 2020-07-30T11:59:41Z

however, since prefix is not defined. The error is thrown.

I think that is a bug in vcpkg_fixup_pkgconfig, that fails in the fixup if the .pc did not contain ${prefix} since the beginning. Not sure if there is any PR that is currently tackling this problem. FYI @Neumann-A

Neumann-A · 2020-07-30T13:44:48Z

Prefix must be defined. Patch the *.pc file if it is not defined in there. pkg-config does not work if the prefix is not defined (with a few exceptions).

GiulioRomualdi · 2020-07-30T20:14:49Z

Prefix must be defined. Patch the *.pc file if it is not defined in there. pkg-config does not work if the prefix is not defined (with a few exceptions).

34ce3a7 should fix the pkg-config issue

Associated issue: coin-or/CppAD#62
Associated PR: coin-or/CppAD#63

NancyLi1013 · 2020-07-31T07:02:23Z

Hi @GiulioRomualdi
For the issue on x86-windows, I cannot reproduce this on my local.
From config-x86-windows-out.log, I got this information, which seems nothing to do with pthread.h. Since pthread.h is only required on Unix platform.

CMake Error at include/cppad/CMakeLists.txt:289 (CONFIGURE_FILE):
  CONFIGURE_FILE Problem configuring file

You might need to check this again.

GiulioRomualdi · 2020-08-01T15:35:41Z

Here I would like to recap the failures in the CI:

x64_windows: failure due to qt5-serialbus:x64-windows

2020-08-01T01:51:27.2140036Z Starting package 456/516: qt5-serialbus:x64-windows
2020-08-01T01:51:27.2145699Z Building package qt5-serialbus[core]:x64-windows...
2020-08-01T01:51:27.2149891Z Using cached binary package: 
W:\2d\2d611a1610935060de78575f299b760d3a2608b2.zip
2020-08-01T01:51:30.6113379Z Building package qt5-serialbus[core]:x64-windows... done
2020-08-01T01:51:30.6119009Z Installing package qt5-serialbus[core]:x64-windows...
2020-08-01T01:51:30.6123374Z The following files are already installed in D:/installed/x64- 
windows and are in conflict with qt5-serialbus:x64-windows
2020-08-01T01:51:30.6125801Z 
2020-08-01T01:51:30.6130360Z Installed by qt5-declarative:x64-windows
2020-08-01T01:51:30.6134706Z     tools/qt5/bin/Qt5Network.dll
2020-08-01T01:51:30.6141040Z     tools/qt5/bin/plugins/bearer/qgenericbearer.dll
2020-08-01T01:51:30.6143604Z 
2020-08-01T01:51:30.6147571Z Elapsed time for package qt5-serialbus:x64-windows: 3.398 s

I don't think it is related to this PR. This is the associated artifact

x64-uwp: fails while configuring ninja This is the associated artifact x64-uwp port build failure logs.zip

arm64-windows: fails while configure ninja

CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
 Command failed: ninja -v
 Working Directory: D:/buildtrees/cppad/arm64-windows-rel/vcpkg-parallel-configure
 Error code: 1
 See logs for more information:
   D:\buildtrees\cppad\config-arm64-windows-out.log

Call Stack (most recent call first):
scripts/cmake/vcpkg_configure_cmake.cmake:300 (vcpkg_execute_required_process)
ports/cppad/portfile.cmake:12 (vcpkg_configure_cmake)
scripts/ports.cmake:79 (include)


Error: Building package cppad:arm64-windows failed with: BUILD_FAILED

This is the associated artifact arm64-windows port build failure logs.zip

arm_uwp: fails while configuring ninja. This is the associated artifact arm-uwp port build failure logs.zip

What do you suggest @NancyLi1013?

NancyLi1013 · 2020-08-04T06:44:47Z

Hi @GiulioRomualdi
Sorry for the late reply.

For the failures on arm64-windows, it is due to this:

-- cppad_tape_id_type_is_unsigned = 0
-- Warning: using a signed cppad_tape_id_type is for CppAD developers only !
-- Performing Test cppad_tape_addr_type_is_unsigned
-- Performing Test cppad_tape_addr_type_is_unsigned - Failed
-- cppad_tape_addr_type_is_unsigned = 0
-- Warning: using a signed cppad_tape_addr_type is for CppAD developers only !
-- Performing Test cppad_max_num_threads_is_integer_ge_4
-- Performing Test cppad_max_num_threads_is_integer_ge_4 - Failed
CMake Error at include/cppad/CMakeLists.txt:256 (MESSAGE):
  cppad_max_num_threads is not an integer greater than or equal 4

For x64-uwp and arm-uwp, it is due to this:

Make Error: TRY_RUN() invoked in cross-compiling mode, please set the following cache variables appropriately:
   cppad_has_signed_long_long_EXITCODE (advanced)
   cppad_has_signed_long_long_EXITCODE__TRYRUN_OUTPUT (advanced)
For details see D:/buildtrees/cppad/x64-uwp-dbg/TryRunResults.cmake
-- Performing Test cppad_has_signed_long_long - Failed
-- cppad_has_signed_long_long = 1
-- Performing Test cppad_has_rvalue
CMake Error: TRY_RUN() invoked in cross-compiling mode, please set the following cache variables appropriately:
   cppad_has_rvalue_EXITCODE (advanced)
   cppad_has_rvalue_EXITCODE__TRYRUN_OUTPUT (advanced)
For details see D:/buildtrees/cppad/x64-uwp-dbg/TryRunResults.cmake
-- Performing Test cppad_has_rvalue - Failed
-- cppad_has_rvalue = 1
-- Performing Test cppad_has_nullptr
CMake Error: TRY_RUN() invoked in cross-compiling mode, please set the following cache variables appropriately:
   cppad_has_nullptr_EXITCODE (advanced)
   cppad_has_nullptr_EXITCODE__TRYRUN_OUTPUT (advanced)
For details see D:/buildtrees/cppad/x64-uwp-dbg/TryRunResults.cmake
-- Performing Test cppad_has_nullptr - Failed
-- cppad_has_nullptr = 1
-- Performing Test cppad_has_long_long
CMake Error: TRY_RUN() invoked in cross-compiling mode, please set the following cache variables appropriately:
   cppad_has_long_long_EXITCODE (advanced)
   cppad_has_long_long_EXITCODE__TRYRUN_OUTPUT (advanced)

These should be bug. You might post these issues to upstream. Or you can add unsupported messages for cppad until they are fixed.
Add Supports: !(arm|uwp) to CONTROL file.
Add vcpkg_fail_port_install(ON_TARGET "uwp" and "arm") to the top of portfile.cmake.

NancyLi1013 · 2020-08-04T06:46:54Z

For the regressions on x64-windows, I will try to reproduce it on my local to confirm if it is a bug.

GiulioRomualdi · 2020-08-04T08:56:06Z

Thanks @NancyLi1013 for the support. I've just opened two issues on the original project to check track the problem:

In the meantime, I will

Add Supports: !(arm|uwp) to CONTROL file.
Add vcpkg_fail_port_install(ON_TARGET "uwp" and "arm") to the top of portfile.cmake.

GiulioRomualdi · 2020-08-04T09:11:35Z

That's strange. Now x64-osx is failing while building pbc (should I rebase this PR on top of master?)

CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
    Command failed: /Users/vagrant/Data/buildtrees/pbc/src/0.5.14-c79affd856.clean/configure --prefix=/Users/vagrant/Data/packages/pbc_x64-osx/debug --enable-static --disable-shared LEX=/usr/bin/flex "YACC=/usr/local/opt/bison/bin/bison -y" --with-sysroot=/Users/vagrant/Data/installed/x64-osx/debug
    Working Directory: /Users/vagrant/Data/buildtrees/pbc/x64-osx-dbg
    Error code: 255
    See logs for more information:
      /Users/vagrant/Data/buildtrees/pbc/configure-x64-osx-dbg-out.log
      /Users/vagrant/Data/buildtrees/pbc/configure-x64-osx-dbg-err.log

Call Stack (most recent call first):
  ports/pbc/portfile.cmake:41 (vcpkg_execute_required_process)
  scripts/ports.cmake:79 (include)


Error: Building package pbc:x64-osx failed with: BUILD_FAILED
Elapsed time for package pbc:x64-osx: 23.02 s

x64-windows fails with the following error

CMake Error: Could not open file for write in copy operation D:/buildtrees/cppad/src/20200000.3-5be66da317.clean/bin/test_one.sh.tmp
CMake Error: : System Error: Permission denied
CMake Error at CMakeLists.txt:350 (CONFIGURE_FILE):
  CONFIGURE_FILE Problem configuring file

Here the artifact generated: x64-windows port build failure logs.zip

NancyLi1013 · 2020-08-04T09:56:14Z

For the failure on x64-osx, you can ignore it, which is not related to this PR. We have fixed it in PR #12732.

For x64-windows, you can add DISABLE_PARALLEL_CONFIGURE to vcpkg_configure_cmake() and then rebuild.

…make() command

NancyLi1013 · 2020-08-05T02:05:41Z

LGTM now. If the two patches in this PR can be accepted by upstream, it will be perfect.

The support for arm and uwp, if it will be fixed by upstream, we can update it later in vcpkg.

GiulioRomualdi · 2020-08-05T08:12:55Z

LGTM now. If the two patches in this PR can be accepted by upstream, it will be perfect.

Since I'm not the maintainer of cppad I don't know what's the pipeline they use for accepting PR. If it's not a problem with you we can merge the PR and then I can take care of updating the port when the PR will be merged.

[CppAD] Add CppAD port

8d636b4

PhoebeHui assigned NancyLi1013 Jul 27, 2020

NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 27, 2020

NancyLi1013 reviewed Jul 27, 2020

View reviewed changes

ports/cppad/portfile.cmake Outdated Show resolved Hide resolved

NancyLi1013 added the requires:author-response label Jul 27, 2020

GiulioRomualdi and others added 2 commits July 27, 2020 11:50

[CppAD] Fix compilation on Linux

f92ebda

[CppAD] Remove vcpkg_common_functions from portfile.cmake

52c528e

Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>

NancyLi1013 suggested changes Jul 28, 2020

View reviewed changes

ports/cppad/portfile.cmake Outdated Show resolved Hide resolved

[CppAD] Avoid to add the postfix 'd' in the debug library

7803ab5

GiulioRomualdi mentioned this pull request Jul 30, 2020

Implement a Eigen-CppAD skeleton gbionics/bipedal-locomotion-framework#78

Merged

[CppAD] Patch the pkgconfig file generation

34ce3a7

GiulioRomualdi mentioned this pull request Jul 30, 2020

Generated pkgconfig file not compliant with the standard coin-or/CppAD#62

Closed

This was referenced Aug 4, 2020

Unable to compile the library on arm64-windows coin-or/CppAD#64

Closed

Unable to compile the CppAD on universal windows platform coin-or/CppAD#65

Closed

[CppAD] Remove the support for uwp and arm

1b94c82

[CppAD] add DISABLE_PARALLEL_CONFIGURE as option of vcpkg_configure_c…

3edc2aa

…make() command

NancyLi1013 approved these changes Aug 6, 2020

View reviewed changes

NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Aug 6, 2020

strega-nil merged commit 222c35e into microsoft:master Aug 7, 2020

GiulioRomualdi mentioned this pull request Sep 2, 2020

Enable cppad on Windows gbionics/bipedal-locomotion-framework#89

Merged

traversaro mentioned this pull request Nov 28, 2020

[OUTDATED] Fix the pkgconfig file generation coin-or/CppAD#63

Closed

Conversation

GiulioRomualdi commented Jul 24, 2020

Uh oh!

Uh oh!

NancyLi1013 commented Jul 27, 2020

Uh oh!

azure-pipelines bot commented Jul 27, 2020

Uh oh!

Uh oh!

NancyLi1013 commented Jul 29, 2020

Uh oh!

azure-pipelines bot commented Jul 29, 2020

Uh oh!

GiulioRomualdi commented Jul 30, 2020

Uh oh!

NancyLi1013 commented Jul 30, 2020

Uh oh!

GiulioRomualdi commented Jul 30, 2020

Uh oh!

GiulioRomualdi commented Jul 30, 2020

Uh oh!

traversaro commented Jul 30, 2020

Uh oh!

Neumann-A commented Jul 30, 2020

Uh oh!

GiulioRomualdi commented Jul 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NancyLi1013 commented Jul 31, 2020

Uh oh!

GiulioRomualdi commented Aug 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NancyLi1013 commented Aug 4, 2020

Uh oh!

NancyLi1013 commented Aug 4, 2020

Uh oh!

GiulioRomualdi commented Aug 4, 2020

Uh oh!

GiulioRomualdi commented Aug 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NancyLi1013 commented Aug 4, 2020

Uh oh!

NancyLi1013 commented Aug 5, 2020

Uh oh!

GiulioRomualdi commented Aug 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

GiulioRomualdi commented Jul 30, 2020 •

edited

Loading

GiulioRomualdi commented Aug 1, 2020 •

edited

Loading

GiulioRomualdi commented Aug 4, 2020 •

edited

Loading