[embree3] Update to 3.11.0#12555
Merged
strega-nil merged 4 commits intomicrosoft:masterfrom Aug 9, 2020
Merged
Conversation
|
|
NancyLi1013
added
the
category:port-update
Remove unused function include(vcpkg_common_functions)
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
suggested changes
Jul 27, 2020
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
approved these changes
Jul 31, 2020
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NancyLi1013
approved these changes
Aug 5, 2020
NancyLi1013
added
the
info:needs-maintainer-attention
strega-nil
reviewed
Aug 7, 2020
| @@ -0,0 +1,4 @@ | |||
| The package embree3 provides CMake targets: | |||
|
|
|||
| find_package(embree 3 CONFIG REQUIRED) | |||
Contributor
There was a problem hiding this comment.
Suggested change
| find_package(embree 3 CONFIG REQUIRED) | |
| find_package(embree3 CONFIG REQUIRED) |
Isn't this the correct find_package?
Contributor
Author
There was a problem hiding this comment.
Yes. Related to #8608, users often use find_package(embree 3).
And also, Upstream README says using FIND_PACKAGE(embree 3.0 REQUIRED).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the latest release v3.11.0.
Outdated patches are replaced.