-
Notifications
You must be signed in to change notification settings - Fork 7.4k
[OpenMVG/OpenMVS] fix tools #12229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
BillyONeal
merged 76 commits into
microsoft:master
from
cenit:dev/cenit/openmvs_openmvg
Aug 28, 2020
Merged
[OpenMVG/OpenMVS] fix tools #12229
Changes from all commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
e07737c
[OpenMVG/OpenMVS] add some features, fix tools
cenit 35611c2
[OpenMVG] copy tools only if feature is enabled
cenit 557f145
[OpenMVG] add a message about graphviz requirement
cenit 4ed4059
[OpenMVS] fix tool paths
cenit 2538599
[OpenMVG] copy OpenCV-enabled tool only if opencv feature is enabled
cenit bdc948e
Merge branch 'master' into dev/cenit/openmvs_openmvg
cenit a087756
[OpenMVS] fixes for OSX
cenit 5c4d2a2
[OpenMVS] improve linux build resiliency
cenit 3c84859
[OpenMVS] fixes when using cmake targets
cenit 5ca639b
[OpenMVS] improve usage for downstream projects
cenit 16aada2
[OpenMVG] improve usage for downstream projects
cenit e1908dc
[OpenMVS] fix tool names also on macOS/linux
cenit 1685d9e
rebuild openblas to check binarycaching
cenit d4021bf
[OpenMVS] simplify patches
cenit 041ccd1
[OpenMVS] improve behaviour for downstream projects
cenit f96b4ec
[clapack] bump to retrigger CI build
cenit ca0cbc6
Merge branch 'master' into dev/cenit/openmvs_openmvg
cenit 21cc849
[qt5-base] add zstd as dependency
cenit b56afd9
Update ports/openmvg/CONTROL
cenit 5b150a4
Update ports/openmvs/CONTROL
cenit 39caea0
Update ports/qt5-base/CONTROL
cenit d1fae65
revert clapack and openblas version bumps
cenit e5e6f1f
[vlfeat] add new port and remove it from 3rd party integrated inside …
cenit 3de5713
[vlfeat] improve compatibility with arm toolchains
cenit ba5d6a6
[vlfeat] remove avx feature because it's broken
cenit 6a50e95
[SuiteSparse] bump to 5.8 trying to fix regressions on linux
cenit 8f849f7
[OpenMVG] fully remove integrated vlfeat
cenit c20fe88
[eigen3] properly handle cmake targets
cenit 14796fe
Merge branch 'master' into dev/cenit/openmvs_openmvg
cenit 076e96d
[suitesparse] add cxsparse cmake module handling
cenit 1a98de6
[nanogui] properly handle eigen3
cenit c0554c9
[ceres] properly handle eigen3
cenit 412cff1
[qt5] fixes #12387
cenit 4a1775e
[ceres] improve handling Eigen3
cenit 98bb209
[vlfeat] trying to fix uwp builds
cenit 0370ea3
fix openblas/lapack, again, like one year ago
cenit 6cfcb56
Merge branch 'master' into dev/cenit/openmvs_openmvg
cenit 9de2f68
Merge branch 'master' into dev/cenit/openmvs_openmvg
cenit 695b788
Update ports/nanogui/CONTROL
cenit b33a6ad
Update ports/nanogui/portfile.cmake
cenit 77ccbd0
[nanogui] revert broken b33a6ad
cenit a05cd00
apply fixes from review
cenit e45075e
Update ports/nanogui/portfile.cmake
cenit d97dff8
Update ports/openmvs/portfile.cmake
cenit 5ca1f0d
Update ports/theia/portfile.cmake
cenit 4a98e90
[eigen3] bump port revision version
cenit 2a29abe
Merge branch 'master' of https://github.com/Microsoft/vcpkg into dev/…
a6327e2
[clapacj] improve pthreads handling
cenit 3682f1f
Merge branch 'master' into dev/cenit/openmvs_openmvg
cenit 869c5cc
Update ports/ceres/0004_fix_find_eigen.patch
cenit a344e11
Merge branch 'master' into dev/cenit/openmvs_openmvg
cenit bc270be
Merge branch 'master' into dev/cenit/openmvs_openmvg
JackBoosY 688e08c
[openmvg] enable port also in single build type triplets
cenit 7a4b522
merge with master
cenit 6912ee3
[suitesparse] depend on lapack metaport
cenit c655b2b
[openmvs] fix case
cenit e66064e
[LAPACK] fix bug that was making LAPACK completely broken outside Win…
cenit ff67f4b
[lapack] bump CONTROL
cenit bb14712
[ceres] bump CONTROL
cenit 2ebd56e
[openblas] bump CONTROL
cenit 24fed1d
[OpenBLAS] now that lapack-reference uses it on osx, remove a dangero…
cenit ef9cae2
wqMerge branch 'master' into dev/cenit/openmvs_openmvg
cenit 4d22962
[openmvs] do not depend on tools in windows static, openmvg has probl…
cenit 4b78d2c
remove openmvs from linux failing list
cenit 85ea382
Merge branch 'master' into dev/cenit/openmvs_openmvg
cenit d893422
[ceres] remove a broken patch which made blas function non resolved
cenit f2a9872
Merge branch 'master' into dev/cenit/openmvs_openmvg
cenit 540ebb3
[SuiteSparse] remove another unnecessary blas-breaking patch
cenit 22db3a6
Update ports/ceres/CONTROL
JackBoosY 3921e9e
Update ports/ceres/portfile.cmake
JackBoosY f0731a7
Merge branch 'master' into dev/cenit/openmvs_openmvg
cenit d29561c
restore qt5-base portfile
cenit 6729cfa
Merge branch 'master' into dev/cenit/openmvs_openmvg
cenit e2c1de8
[OpenMVG] error message when static CRT linking and software tools fe…
cenit 93fb76b
[mlpack] fix tools regression
cenit ea517c4
Update ports/suitesparse/CONTROL
NancyLi1013 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| Source: armadillo | ||
| Version: 2019-04-16 | ||
| Port-Version: 9 | ||
| Port-Version: 10 | ||
| Description: Armadillo is a high quality linear algebra library (matrix maths) for the C++ language, aiming towards a good balance between speed and ease of use | ||
| Build-Depends: openblas (!osx), lapack | ||
| Build-Depends: openblas, lapack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
| index 7033de0..5235baa 100644 | ||
| --- a/CMakeLists.txt | ||
| +++ b/CMakeLists.txt | ||
| @@ -209,40 +209,40 @@ endif (IOS) | ||
| unset(CERES_COMPILE_OPTIONS) | ||
|
|
||
| # Eigen. | ||
| -find_package(Eigen REQUIRED) | ||
| -if (EIGEN_FOUND) | ||
| - message("-- Found Eigen version ${EIGEN_VERSION}: ${EIGEN_INCLUDE_DIRS}") | ||
| - if (EIGEN_VERSION VERSION_LESS 3.1.0) | ||
| +find_package(Eigen3 REQUIRED) | ||
| +if (EIGEN3_FOUND) | ||
| + message(STATUS "Found Eigen version ${EIGEN3_VERSION_STRING}: ${EIGEN3_INCLUDE_DIRS}") | ||
| + if (EIGEN3_VERSION_STRING VERSION_LESS 3.1.0) | ||
| message(FATAL_ERROR "-- Ceres requires Eigen version >= 3.1.0 in order " | ||
| "that Eigen/SparseCore be available, detected version of Eigen is: " | ||
| - "${EIGEN_VERSION}") | ||
| - endif (EIGEN_VERSION VERSION_LESS 3.1.0) | ||
| + "${EIGEN3_VERSION_STRING}") | ||
| + endif (EIGEN3_VERSION_STRING VERSION_LESS 3.1.0) | ||
|
|
||
| if (CMAKE_SYSTEM_PROCESSOR MATCHES "^(aarch64.*|AARCH64.*)" AND | ||
| - EIGEN_VERSION VERSION_LESS 3.3.4) | ||
| + EIGEN3_VERSION_STRING VERSION_LESS 3.3.4) | ||
| # As per issue #289: https://github.com/ceres-solver/ceres-solver/issues/289 | ||
| # the bundle_adjustment_test will fail for Eigen < 3.3.4 on aarch64. | ||
| message(FATAL_ERROR "-- Ceres requires Eigen version >= 3.3.4 on aarch64. " | ||
| - "Detected version of Eigen is: ${EIGEN_VERSION}.") | ||
| + "Detected version of Eigen is: ${EIGEN3_VERSION_STRING}.") | ||
| endif() | ||
|
|
||
| if (EIGENSPARSE) | ||
| - message("-- Enabling use of Eigen as a sparse linear algebra library.") | ||
| + message(STATUS "Enabling use of Eigen as a sparse linear algebra library.") | ||
| list(APPEND CERES_COMPILE_OPTIONS CERES_USE_EIGEN_SPARSE) | ||
| - if (EIGEN_VERSION VERSION_LESS 3.2.2) | ||
| + if (EIGEN3_VERSION_STRING VERSION_LESS 3.2.2) | ||
| message(" WARNING:") | ||
| message("") | ||
| - message(" Your version of Eigen (${EIGEN_VERSION}) is older than ") | ||
| + message(" Your version of Eigen (${EIGEN3_VERSION_STRING}) is older than ") | ||
| message(" version 3.2.2. The performance of SPARSE_NORMAL_CHOLESKY ") | ||
| message(" and SPARSE_SCHUR linear solvers will suffer.") | ||
| - endif (EIGEN_VERSION VERSION_LESS 3.2.2) | ||
| + endif (EIGEN3_VERSION_STRING VERSION_LESS 3.2.2) | ||
| else (EIGENSPARSE) | ||
| message("-- Disabling use of Eigen as a sparse linear algebra library.") | ||
| message(" This does not affect the covariance estimation algorithm ") | ||
| message(" which can still use the EIGEN_SPARSE_QR algorithm.") | ||
| add_definitions(-DEIGEN_MPL2_ONLY) | ||
| endif (EIGENSPARSE) | ||
| -endif (EIGEN_FOUND) | ||
| +endif (EIGEN3_FOUND) | ||
|
|
||
| if (LAPACK) | ||
| find_package(LAPACK QUIET) | ||
| @@ -562,7 +562,7 @@ include_directories( | ||
| # Note that this is *not* propagated to clients, ie CERES_INCLUDE_DIRS | ||
| # used by clients after find_package(Ceres) does not identify Eigen as | ||
| # as system headers. | ||
| -include_directories(SYSTEM ${EIGEN_INCLUDE_DIRS}) | ||
| +include_directories(${EIGEN3_INCLUDE_DIRS}) | ||
cenit marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| if (SUITESPARSE) | ||
| include_directories(${SUITESPARSE_INCLUDE_DIRS}) | ||
| diff --git a/cmake/CeresConfig.cmake.in b/cmake/CeresConfig.cmake.in | ||
| index c4ed71f..b3d6a17 100644 | ||
| --- a/cmake/CeresConfig.cmake.in | ||
| +++ b/cmake/CeresConfig.cmake.in | ||
| @@ -202,39 +202,39 @@ set(CERES_VERSION @CERES_VERSION@ ) | ||
|
|
||
| # Eigen. | ||
| # Flag set during configuration and build of Ceres. | ||
| -set(CERES_EIGEN_VERSION @EIGEN_VERSION@) | ||
| +set(CERES_EIGEN_VERSION @EIGEN3_VERSION_STRING@) | ||
| set(EIGEN_WAS_BUILT_WITH_CMAKE @FOUND_INSTALLED_EIGEN_CMAKE_CONFIGURATION@) | ||
| # Append the locations of Eigen when Ceres was built to the search path hints. | ||
| if (EIGEN_WAS_BUILT_WITH_CMAKE) | ||
| set(Eigen3_DIR @Eigen3_DIR@) | ||
| set(EIGEN_PREFER_EXPORTED_EIGEN_CMAKE_CONFIGURATION TRUE) | ||
| else() | ||
| - list(APPEND EIGEN_INCLUDE_DIR_HINTS @EIGEN_INCLUDE_DIR@) | ||
| + list(APPEND EIGEN_INCLUDE_DIR_HINTS @EIGEN3_INCLUDE_DIR@) | ||
cenit marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| endif() | ||
| # Search quietly to control the timing of the error message if not found. The | ||
| # search should be for an exact match, but for usability reasons do a soft | ||
| # match and reject with an explanation below. | ||
| -find_package(Eigen ${CERES_EIGEN_VERSION} QUIET) | ||
| -if (EIGEN_FOUND) | ||
| - if (NOT EIGEN_VERSION VERSION_EQUAL CERES_EIGEN_VERSION) | ||
| +find_package(Eigen3 ${CERES_EIGEN_VERSION} QUIET) | ||
cenit marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| +if (EIGEN3_FOUND) | ||
| + if (NOT EIGEN3_VERSION_STRING VERSION_EQUAL CERES_EIGEN_VERSION) | ||
| # CMake's VERSION check in FIND_PACKAGE() will accept any version >= the | ||
| # specified version. However, only version = is supported. Improve | ||
| # usability by explaining why we don't accept non-exact version matching. | ||
| ceres_report_not_found("Found Eigen dependency, but the version of Eigen " | ||
| - "found (${EIGEN_VERSION}) does not exactly match the version of Eigen " | ||
| + "found (${EIGEN3_VERSION_STRING}) does not exactly match the version of Eigen " | ||
| "Ceres was compiled with (${CERES_EIGEN_VERSION}). This can cause subtle " | ||
| "bugs by triggering violations of the One Definition Rule. See the " | ||
| "Wikipedia article http://en.wikipedia.org/wiki/One_Definition_Rule " | ||
| "for more details") | ||
| endif () | ||
| message(STATUS "Found required Ceres dependency: " | ||
| - "Eigen version ${CERES_EIGEN_VERSION} in ${EIGEN_INCLUDE_DIRS}") | ||
| -else (EIGEN_FOUND) | ||
| + "Eigen version ${CERES_EIGEN_VERSION} in ${EIGEN3_INCLUDE_DIRS}") | ||
| +else (EIGEN3_FOUND) | ||
| ceres_report_not_found("Missing required Ceres " | ||
| "dependency: Eigen version ${CERES_EIGEN_VERSION}, please set " | ||
| - "EIGEN_INCLUDE_DIR.") | ||
| -endif (EIGEN_FOUND) | ||
| -list(APPEND CERES_INCLUDE_DIRS ${EIGEN_INCLUDE_DIRS}) | ||
| + "EIGEN3_INCLUDE_DIR.") | ||
| +endif (EIGEN3_FOUND) | ||
| +list(APPEND CERES_INCLUDE_DIRS ${EIGEN3_INCLUDE_DIRS}) | ||
|
|
||
| # Glog. | ||
| include (CMakeFindDependencyMacro) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| Source: eigen3 | ||
| Version: 3.3.7 | ||
| Port-Version: 6 | ||
| Port-Version: 7 | ||
| Homepage: http://eigen.tuxfamily.org | ||
| Description: C++ template library for linear algebra: matrices, vectors, numerical solvers, and related algorithms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| Source: ensmallen | ||
| Version: 2.11.2 | ||
| Port-Version: 1 | ||
| Port-Version: 2 | ||
| Homepage: https://github.com/mlpack/ensmallen | ||
| Description: A header-only C++ library for mathematical optimization. | ||
| Build-Depends: openblas (!osx), lapack, armadillo | ||
|
|
||
| Build-Depends: openblas, lapack, armadillo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -482,7 +482,7 @@ if(BLAS_FOUND) | |
| LAPACK | ||
| cheev | ||
| "" | ||
| "lapack;-lm;-lgfortran" | ||
| "lapack;m;gfortran" | ||
| "" | ||
| "" | ||
| "" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| Source: lapack | ||
| Version: 1 | ||
| Version: 2 | ||
| Description: Metapackage for packages which provide LAPACK | ||
| Build-Depends: clapack ((arm&windows)|uwp), lapack-reference(!uwp&!(arm&windows)) | ||
| Build-Depends: clapack ((arm&windows)|uwp), lapack-reference(!uwp&!(arm&windows)) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.